From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2B0481363 for ; Tue, 23 Nov 2021 10:49:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D043F8D49 for ; Tue, 23 Nov 2021 10:49:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 457B48D40 for ; Tue, 23 Nov 2021 10:49:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 21CBB443CF for ; Tue, 23 Nov 2021 10:49:36 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 23 Nov 2021 10:49:35 +0100 Message-Id: <20211123094935.2303969-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.205 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] ui: journalview: fix wrong first load with timespan X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 09:49:36 -0000 calling updateParams here lead to making an api call with the default timespan (last 3 days) on pbs/pmg when going to the 'administration' panel, even though it would never be shown since on tab activate we would show the 'live mode' which does not use the timespan on pve this did not happen since the journalview is on its own page and the change to livemode triggered too fast.. Signed-off-by: Dominik Csapak --- src/panel/JournalView.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/panel/JournalView.js b/src/panel/JournalView.js index f672be1..c74345f 100644 --- a/src/panel/JournalView.js +++ b/src/panel/JournalView.js @@ -198,7 +198,6 @@ Ext.define('Proxmox.panel.JournalView', { view.loadTask = new Ext.util.DelayedTask(me.doLoad, me, [true, false]); - me.updateParams(); view.task = Ext.TaskManager.start({ run: function() { if (!view.isVisible() || !view.scrollToEnd || !viewmodel.get('livemode')) { -- 2.30.2