From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1E300812BF for ; Tue, 23 Nov 2021 08:50:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 101EB26DA8 for ; Tue, 23 Nov 2021 08:49:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3C88026D8D for ; Tue, 23 Nov 2021 08:49:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C2E954265E for ; Tue, 23 Nov 2021 08:49:35 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 23 Nov 2021 08:49:33 +0100 Message-Id: <20211123074935.736530-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211123074935.736530-1-d.csapak@proxmox.com> References: <20211123074935.736530-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.206 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 1/3] ui: logpanel: fix glitching on fast task logs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 07:50:12 -0000 when we follow (scrollToEnd === true) a task log that produces many lines per second, we often get a 'total' back that exceeds our start+limit. in that case we do not want to pad the bottom of the task log with empty lines, we only want that for finished task logs to preserve the scroll bar position+size. Signed-off-by: Dominik Csapak --- src/panel/LogView.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/panel/LogView.js b/src/panel/LogView.js index 1772737..bbf38ee 100644 --- a/src/panel/LogView.js +++ b/src/panel/LogView.js @@ -97,7 +97,9 @@ Ext.define('Proxmox.panel.LogView', { lines[line.n - 1] = Ext.htmlEncode(line.t); }); - lines.length = total; + if (!view.scrollToEnd) { + lines.length = total; + } me.updateView(lines.join('
'), first - 1, total); me.running = false; if (me.requested) { -- 2.30.2