From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8F2468093B for ; Thu, 18 Nov 2021 14:28:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67FC41C3FF for ; Thu, 18 Nov 2021 14:28:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8165A1C3E4 for ; Thu, 18 Nov 2021 14:28:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 21E9344B9A for ; Thu, 18 Nov 2021 14:28:32 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 18 Nov 2021 14:28:29 +0100 Message-Id: <20211118132831.839774-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.213 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/3] pvescheduler: catch errors in forked childs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 13:28:33 -0000 if '$sub' dies, the error handler of PVE::Daemon triggers, which initiates a shutdown of the child, resulting in confusing error logs (e.g. 'got shutdown request, signal running jobs to stop') instead, run it under 'eval' and print the error to the sylog instead Signed-off-by: Dominik Csapak --- PVE/Service/pvescheduler.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/Service/pvescheduler.pm b/PVE/Service/pvescheduler.pm index 9f5c4515..d4f73702 100755 --- a/PVE/Service/pvescheduler.pm +++ b/PVE/Service/pvescheduler.pm @@ -47,7 +47,12 @@ sub run { die "fork failed: $!\n"; } elsif ($child == 0) { $self->after_fork_cleanup(); - $sub->(); + eval { + $sub->(); + }; + if (my $err = $@) { + syslog('err', "ERROR: $err"); + } POSIX::_exit(0); } -- 2.30.2