From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15F9C807B9 for ; Thu, 18 Nov 2021 10:50:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0A43218958 for ; Thu, 18 Nov 2021 10:50:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 977281894F for ; Thu, 18 Nov 2021 10:50:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6AA6943DD0 for ; Thu, 18 Nov 2021 10:50:11 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 18 Nov 2021 10:50:10 +0100 Message-Id: <20211118095010.2387263-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.213 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 09:50:12 -0000 the change from extjs 6.0.1 to 7.0.0 removed 'onDestroy' but brought us 'doDestroy' for stores we did not notice since 'onDestroy' was a private method and thus the changelog did not mention this (doDestroy is a public method meant exactly for our use case) Signed-off-by: Dominik Csapak --- src/data/DiffStore.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data/DiffStore.js b/src/data/DiffStore.js index e4143f5..935bc11 100644 --- a/src/data/DiffStore.js +++ b/src/data/DiffStore.js @@ -28,7 +28,7 @@ Ext.define('Proxmox.data.DiffStore', { // config is passed instead of an existing rstore instance autoDestroyRstore: false, - onDestroy: function() { + doDestroy: function() { let me = this; if (me.autoDestroyRstore) { if (Ext.isFunction(me.rstore.destroy)) { -- 2.30.2