From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF63680728 for ; Thu, 18 Nov 2021 08:06:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA21C16933 for ; Thu, 18 Nov 2021 08:05:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2A2C716928 for ; Thu, 18 Nov 2021 08:05:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E2FEF43D54 for ; Thu, 18 Nov 2021 08:05:38 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 18 Nov 2021 08:05:38 +0100 Message-Id: <20211118070538.357481-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.213 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu] fix dependencies on headers for 'vma' and 'pbs_restore' X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2021 07:06:09 -0000 both of them depend on generated header files, so we have to specify them as sources. Otherwise, it happens (at least on some machines) that they will be compiled before the headers are generated, aborting the build. Signed-off-by: Dominik Csapak --- thanks @wolfgang for helping me understand meson a bit better ;) .../pve/0025-PVE-Backup-add-vma-backup-format-code.patch | 2 +- ...PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/debian/patches/pve/0025-PVE-Backup-add-vma-backup-format-code.patch b/debian/patches/pve/0025-PVE-Backup-add-vma-backup-format-code.patch index 0e939bf..31cd97e 100644 --- a/debian/patches/pve/0025-PVE-Backup-add-vma-backup-format-code.patch +++ b/debian/patches/pve/0025-PVE-Backup-add-vma-backup-format-code.patch @@ -46,7 +46,7 @@ index b3e7ec0e92..b84f62f882 100644 qemu_nbd = executable('qemu-nbd', files('qemu-nbd.c'), dependencies: [blockdev, qemuutil, gnutls], install: true) -+ vma = executable('vma', files('vma.c', 'vma-reader.c'), ++ vma = executable('vma', files('vma.c', 'vma-reader.c') + genh, + dependencies: [authz, block, crypto, io, qom], install: true) + subdir('storage-daemon') diff --git a/debian/patches/pve/0028-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch b/debian/patches/pve/0028-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch index 8178a13..c5ae406 100644 --- a/debian/patches/pve/0028-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch +++ b/debian/patches/pve/0028-PVE-Backup-pbs-restore-new-command-to-restore-from-p.patch @@ -16,10 +16,10 @@ index c05c926cc3..69a0fe80ef 100644 --- a/meson.build +++ b/meson.build @@ -2749,6 +2749,10 @@ if have_tools - vma = executable('vma', files('vma.c', 'vma-reader.c'), + vma = executable('vma', files('vma.c', 'vma-reader.c') + genh, dependencies: [authz, block, crypto, io, qom], install: true) -+ pbs_restore = executable('pbs-restore', files('pbs-restore.c'), ++ pbs_restore = executable('pbs-restore', files('pbs-restore.c') + genh, + dependencies: [authz, block, crypto, io, qom, + libproxmox_backup_qemu], install: true) + -- 2.30.2