From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3E1887FC17 for ; Mon, 15 Nov 2021 13:38:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3244BA67D for ; Mon, 15 Nov 2021 13:38:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7A5D1A667 for ; Mon, 15 Nov 2021 13:38:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 486CE43AC1 for ; Mon, 15 Nov 2021 13:38:00 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 15 Nov 2021 13:37:56 +0100 Message-Id: <20211115123756.146659-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211115123756.146659-1-f.ebner@proxmox.com> References: <20211115123756.146659-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.182 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 12:38:38 -0000 in the same manner as NT_STATUS_ACCESS_DENIED. It can be assumed to be a configuration error, so avoid showing the generic "storage is not online". Reported in the community forum: https://forum.proxmox.com/threads/storage-is-not-online-cifs.99201/post-428858 Signed-off-by: Fabian Ebner --- PVE/Storage/CIFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index a3f9ebe..d5efa5f 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -280,7 +280,7 @@ sub check_connection { if (my $err = $@) { die "$out_str\n" if defined($out_str) && - ($out_str =~ m/NT_STATUS_ACCESS_DENIED/); + ($out_str =~ m/NT_STATUS_(ACCESS_DENIED|LOGON_FAILURE)/); return 0; } -- 2.30.2