From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E4A2D7F4A7 for ; Fri, 12 Nov 2021 13:23:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC748197B6 for ; Fri, 12 Nov 2021 13:23:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 58D96197AD for ; Fri, 12 Nov 2021 13:23:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2CE4C43667 for ; Fri, 12 Nov 2021 13:23:54 +0100 (CET) From: Wolfgang Bumiller To: pve-devel@lists.proxmox.com Date: Fri, 12 Nov 2021 13:23:53 +0100 Message-Id: <20211112122353.111086-1-w.bumiller@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.469 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvestatd.pm] Subject: [pve-devel] [PATCH manager] pvestatd: rebroadcast version info as needed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 12:23:54 -0000 since this is just in-memory data and can get lost with pmxcfs restarts Signed-off-by: Wolfgang Bumiller Fixes: 34a1305e9c21 ("pvestatd: broadcast version info") --- PVE/Service/pvestatd.pm | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index b1e71ec8..6a413025 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -491,15 +491,16 @@ sub update_sdn_status { } } -my $broadcast_version_info_done = 0; +my $version_info; my sub broadcast_version_info : prototype() { - if (!$broadcast_version_info_done) { - PVE::Cluster::broadcast_node_kv( - 'version-info', - encode_json(PVE::pvecfg::version_info()), - ); - $broadcast_version_info_done = 1; + $version_info //= to_json(PVE::pvecfg::version_info(), { canonical => 1 }); + + if (my $old = PVE::Cluster::get_node_kv("version-info")) { + $old = $old->{$nodename}; + return if $old && $old eq $version_info; } + + PVE::Cluster::broadcast_node_kv('version-info', $version_info); } sub update_status { -- 2.30.2