From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0F30F7F2E6 for ; Fri, 12 Nov 2021 10:53:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 01ADC171E0 for ; Fri, 12 Nov 2021 10:53:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0760F171C4 for ; Fri, 12 Nov 2021 10:53:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C9337402E5 for ; Fri, 12 Nov 2021 10:53:36 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 12 Nov 2021 10:53:32 +0100 Message-Id: <20211112095335.1839765-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211112095335.1839765-1-a.lauterer@proxmox.com> References: <20211112095335.1839765-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/4] ui: qm: disk selection: add optional selection of unused X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 09:53:38 -0000 With this optional setting, it is possible to allow the user to also select 'unused' as a disk bus type. Signed-off-by: Aaron Lauterer --- www/manager6/Utils.js | 1 + www/manager6/form/BusTypeSelector.js | 5 +++++ www/manager6/form/ControllerSelector.js | 2 ++ 3 files changed, 8 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 274d4db2..1aaa5085 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1548,6 +1548,7 @@ Ext.define('PVE.Utils', { sata: 6, scsi: 31, virtio: 16, + unused: 256, }, // types is either undefined (all busses), an array of busses, or a single bus diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js index 13027f5a..a420e56f 100644 --- a/www/manager6/form/BusTypeSelector.js +++ b/www/manager6/form/BusTypeSelector.js @@ -3,6 +3,7 @@ Ext.define('PVE.form.BusTypeSelector', { alias: 'widget.pveBusSelector', noVirtIO: false, + withUnused: false, initComponent: function() { var me = this; @@ -15,6 +16,10 @@ Ext.define('PVE.form.BusTypeSelector', { me.comboItems.push(['scsi', 'SCSI']); + if (me.withUnused) { + me.comboItems.push(['unused', 'Unused']); + } + me.callParent(); }, }); diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 71332db5..798dc4b2 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/manager6/form/ControllerSelector.js @@ -3,6 +3,7 @@ Ext.define('PVE.form.ControllerSelector', { alias: 'widget.pveControllerSelector', noVirtIO: false, + withUnused: false, vmconfig: {}, // used to check for existing devices @@ -73,6 +74,7 @@ Ext.define('PVE.form.ControllerSelector', { itemId: 'controller', value: PVE.qemu.OSDefaults.generic.busType, noVirtIO: me.noVirtIO, + withUnused: me.withUnused, allowBlank: false, flex: 2, listeners: { -- 2.30.2