From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 26BC17ED82 for ; Thu, 11 Nov 2021 15:07:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4FBF4CBD6 for ; Thu, 11 Nov 2021 15:07:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7E368C76C for ; Thu, 11 Nov 2021 15:07:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4570743422 for ; Thu, 11 Nov 2021 15:07:32 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Thu, 11 Nov 2021 15:07:19 +0100 Message-Id: <20211111140721.3288364-14-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211111140721.3288364-1-f.gruenbichler@proxmox.com> References: <20211111140721.3288364-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.266 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 qemu-server 6/8] migrate: refactor remote VM/tunnel start X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 14:07:41 -0000 no semantic changes intended, except for: - no longer passing the main migration UNIX socket to SSH twice for forwarding - dropping the 'unix:' prefix in start_remote_tunnel's timeout error message Signed-off-by: Fabian Grünbichler --- Notes: v2: fixed nits PVE/QemuMigrate.pm | 158 ++++++++++++++++++++++++++++----------------- PVE/QemuServer.pm | 34 +++++----- 2 files changed, 113 insertions(+), 79 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 779f5ee..461ac95 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -206,19 +206,24 @@ sub finish_tunnel { die $err if $err; } +# tunnel_info: +# proto: unix (secure) or tcp (insecure/legacy compat) +# addr: IP or UNIX socket path +# port: optional TCP port +# unix_sockets: additional UNIX socket paths to forward sub start_remote_tunnel { - my ($self, $raddr, $rport, $ruri, $unix_socket_info) = @_; + my ($self, $tunnel_info) = @_; my $nodename = PVE::INotify::nodename(); my $migration_type = $self->{opts}->{migration_type}; if ($migration_type eq 'secure') { - if ($ruri =~ /^unix:/) { - my $ssh_forward_info = ["$raddr:$raddr"]; - $unix_socket_info->{$raddr} = 1; + if ($tunnel_info->{proto} eq 'unix') { + my $ssh_forward_info = []; - my $unix_sockets = [ keys %$unix_socket_info ]; + my $unix_sockets = [ keys %{$tunnel_info->{unix_sockets}} ]; + push @$unix_sockets, $tunnel_info->{addr}; for my $sock (@$unix_sockets) { push @$ssh_forward_info, "$sock:$sock"; unlink $sock; @@ -245,23 +250,23 @@ sub start_remote_tunnel { if ($unix_socket_try > 100) { $self->{errors} = 1; $self->finish_tunnel($self->{tunnel}); - die "Timeout, migration socket $ruri did not get ready"; + die "Timeout, migration socket $tunnel_info->{addr} did not get ready"; } $self->{tunnel}->{unix_sockets} = $unix_sockets if (@$unix_sockets); - } elsif ($ruri =~ /^tcp:/) { + } elsif ($tunnel_info->{proto} eq 'tcp') { my $ssh_forward_info = []; - if ($raddr eq "localhost") { + if ($tunnel_info->{addr} eq "localhost") { # for backwards compatibility with older qemu-server versions my $pfamily = PVE::Tools::get_host_address_family($nodename); my $lport = PVE::Tools::next_migrate_port($pfamily); - push @$ssh_forward_info, "$lport:localhost:$rport"; + push @$ssh_forward_info, "$lport:localhost:$tunnel_info->{rport}"; } $self->{tunnel} = $self->fork_tunnel($ssh_forward_info); } else { - die "unsupported protocol in migration URI: $ruri\n"; + die "unsupported protocol in migration URI: $tunnel_info->{proto}\n"; } } else { #fork tunnel for insecure migration, to send faster commands like resume @@ -813,52 +818,40 @@ sub phase1_cleanup { } } -sub phase2 { - my ($self, $vmid) = @_; +sub phase2_start_local_cluster { + my ($self, $vmid, $params) = @_; my $conf = $self->{vmconf}; my $local_volumes = $self->{local_volumes}; my @online_local_volumes = $self->filter_local_volumes('online'); $self->{storage_migration} = 1 if scalar(@online_local_volumes); + my $start = $params->{start_params}; + my $migrate = $params->{migrate_opts}; $self->log('info', "starting VM $vmid on remote node '$self->{node}'"); - my $raddr; - my $rport; - my $ruri; # the whole migration dst. URI (protocol:address[:port]) - my $nodename = PVE::INotify::nodename(); + my $tunnel_info = {}; ## start on remote node my $cmd = [@{$self->{rem_ssh}}]; - my $spice_ticket; - if (PVE::QemuServer::vga_conf_has_spice($conf->{vga})) { - my $res = mon_cmd($vmid, 'query-spice'); - $spice_ticket = $res->{ticket}; - } + push @$cmd, 'qm', 'start', $vmid, '--skiplock'; + push @$cmd, '--migratedfrom', $migrate->{migratedfrom}; - push @$cmd , 'qm', 'start', $vmid, '--skiplock', '--migratedfrom', $nodename; + push @$cmd, '--migration_type', $migrate->{type}; - my $migration_type = $self->{opts}->{migration_type}; + push @$cmd, '--migration_network', $migrate->{network} + if $migrate->{network}; - push @$cmd, '--migration_type', $migration_type; + push @$cmd, '--stateuri', $start->{statefile}; - push @$cmd, '--migration_network', $self->{opts}->{migration_network} - if $self->{opts}->{migration_network}; - - if ($migration_type eq 'insecure') { - push @$cmd, '--stateuri', 'tcp'; - } else { - push @$cmd, '--stateuri', 'unix'; + if ($start->{forcemachine}) { + push @$cmd, '--machine', $start->{forcemachine}; } - if ($self->{forcemachine}) { - push @$cmd, '--machine', $self->{forcemachine}; - } - - if ($self->{forcecpu}) { - push @$cmd, '--force-cpu', $self->{forcecpu}; + if ($start->{forcecpu}) { + push @$cmd, '--force-cpu', $start->{forcecpu}; } if ($self->{storage_migration}) { @@ -866,11 +859,8 @@ sub phase2 { } my $spice_port; - my $unix_socket_info = {}; - # version > 0 for unix socket support - my $nbd_protocol_version = 1; - my $input = "nbd_protocol_version: $nbd_protocol_version\n"; - $input .= "spice_ticket: $spice_ticket\n" if $spice_ticket; + my $input = "nbd_protocol_version: $migrate->{nbd_proto_version}\n"; + $input .= "spice_ticket: $migrate->{spice_ticket}\n" if $migrate->{spice_ticket}; my @online_replicated_volumes = $self->filter_local_volumes('online', 1); foreach my $volid (@online_replicated_volumes) { @@ -900,20 +890,20 @@ sub phase2 { my $exitcode = PVE::Tools::run_command($cmd, input => $input, outfunc => sub { my $line = shift; - if ($line =~ m/^migration listens on tcp:(localhost|[\d\.]+|\[[\d\.:a-fA-F]+\]):(\d+)$/) { - $raddr = $1; - $rport = int($2); - $ruri = "tcp:$raddr:$rport"; + if ($line =~ m/^migration listens on (tcp):(localhost|[\d\.]+|\[[\d\.:a-fA-F]+\]):(\d+)$/) { + $tunnel_info->{addr} = $2; + $tunnel_info->{port} = int($3); + $tunnel_info->{proto} = $1; } - elsif ($line =~ m!^migration listens on unix:(/run/qemu-server/(\d+)\.migrate)$!) { - $raddr = $1; - die "Destination UNIX sockets VMID does not match source VMID" if $vmid ne $2; - $ruri = "unix:$raddr"; + elsif ($line =~ m!^migration listens on (unix):(/run/qemu-server/(\d+)\.migrate)$!) { + $tunnel_info->{addr} = $2; + die "Destination UNIX sockets VMID does not match source VMID" if $vmid ne $3; + $tunnel_info->{proto} = $1; } elsif ($line =~ m/^migration listens on port (\d+)$/) { - $raddr = "localhost"; - $rport = int($1); - $ruri = "tcp:$raddr:$rport"; + $tunnel_info->{addr} = "localhost"; + $tunnel_info->{port} = int($1); + $tunnel_info->{proto} = "tcp"; } elsif ($line =~ m/^spice listens on port (\d+)$/) { $spice_port = int($1); @@ -934,7 +924,7 @@ sub phase2 { $targetdrive =~ s/drive-//g; $handle_storage_migration_listens->($targetdrive, $drivestr, $nbd_uri); - $unix_socket_info->{$nbd_unix_addr} = 1; + $tunnel_info->{unix_sockets}->{$nbd_unix_addr} = 1; } elsif ($line =~ m/^re-using replicated volume: (\S+) - (.*)$/) { my $drive = $1; my $volid = $2; @@ -949,19 +939,65 @@ sub phase2 { die "remote command failed with exit code $exitcode\n" if $exitcode; - die "unable to detect remote migration address\n" if !$raddr; + die "unable to detect remote migration address\n" if !$tunnel_info->{addr} || !$tunnel_info->{proto}; if (scalar(keys %$target_replicated_volumes) != scalar(@online_replicated_volumes)) { die "number of replicated disks on source and target node do not match - target node too old?\n" } + return ($tunnel_info, $spice_port); +} + +sub phase2 { + my ($self, $vmid) = @_; + + my $conf = $self->{vmconf}; + + # version > 0 for unix socket support + my $nbd_protocol_version = 1; + + my $spice_ticket; + if (PVE::QemuServer::vga_conf_has_spice($conf->{vga})) { + my $res = mon_cmd($vmid, 'query-spice'); + $spice_ticket = $res->{ticket}; + } + + my $migration_type = $self->{opts}->{migration_type}; + my $state_uri = $migration_type eq 'insecure' ? 'tcp' : 'unix'; + + my $params = { + start_params => { + statefile => $state_uri, + forcemachine => $self->{forcemachine}, + forcecpu => $self->{forcecpu}, + skiplock => 1, + }, + migrate_opts => { + spice_ticket => $spice_ticket, + type => $migration_type, + network => $self->{opts}->{migration_network}, + storagemap => $self->{opts}->{storagemap}, + migratedfrom => PVE::INotify::nodename(), + nbd_proto_version => $nbd_protocol_version, + nbd => $self->{nbd}, + }, + }; + + my ($tunnel_info, $spice_port) = $self->phase2_start_local_cluster($vmid, $params); + $self->log('info', "start remote tunnel"); - $self->start_remote_tunnel($raddr, $rport, $ruri, $unix_socket_info); + $self->start_remote_tunnel($tunnel_info); + + my $migrate_uri = "$tunnel_info->{proto}:$tunnel_info->{addr}"; + $migrate_uri .= ":$tunnel_info->{port}" + if defined($tunnel_info->{port}); if ($self->{storage_migration}) { $self->{storage_migration_jobs} = {}; $self->log('info', "starting storage migration"); + my @online_local_volumes = $self->filter_local_volumes('online'); + die "The number of local disks does not match between the source and the destination.\n" if (scalar(keys %{$self->{target_drive}}) != scalar(@online_local_volumes)); foreach my $drive (keys %{$self->{target_drive}}){ @@ -971,7 +1007,7 @@ sub phase2 { my $source_drive = PVE::QemuServer::parse_drive($drive, $conf->{$drive}); my $source_volid = $source_drive->{file}; - my $bwlimit = $local_volumes->{$source_volid}->{bwlimit}; + my $bwlimit = $self->{local_volumes}->{$source_volid}->{bwlimit}; my $bitmap = $target->{bitmap}; $self->log('info', "$drive: start migration to $nbd_uri"); @@ -979,7 +1015,7 @@ sub phase2 { } } - $self->log('info', "starting online/live migration on $ruri"); + $self->log('info', "starting online/live migration on $migrate_uri"); $self->{livemigration} = 1; # load_defaults @@ -1056,12 +1092,12 @@ sub phase2 { my $start = time(); - $self->log('info', "start migrate command to $ruri"); + $self->log('info', "start migrate command to $migrate_uri"); eval { - mon_cmd($vmid, "migrate", uri => $ruri); + mon_cmd($vmid, "migrate", uri => $migrate_uri); }; my $merr = $@; - $self->log('info', "migrate uri => $ruri failed: $merr") if $merr; + $self->log('info', "migrate uri => $migrate_uri failed: $merr") if $merr; my $last_mem_transferred = 0; my $usleep = 1000000; diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 387f71e..4396a36 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5451,10 +5451,10 @@ sub vm_start_nolock { return $migration_ip; }; - my $migrate_uri; if ($statefile) { if ($statefile eq 'tcp') { - my $localip = "localhost"; + my $migrate = $res->{migrate} = { proto => 'tcp' }; + $migrate->{addr} = "localhost"; my $datacenterconf = PVE::Cluster::cfs_read_file('datacenter.cfg'); my $nodename = nodename(); @@ -5467,26 +5467,26 @@ sub vm_start_nolock { } if ($migration_type eq 'insecure') { - $localip = $get_migration_ip->($nodename); - $localip = "[$localip]" if Net::IP::ip_is_ipv6($localip); + $migrate->{addr} = $get_migration_ip->($nodename); + $migrate->{addr} = "[$migrate->{addr}]" if Net::IP::ip_is_ipv6($migrate->{addr}); } my $pfamily = PVE::Tools::get_host_address_family($nodename); - my $migrate_port = PVE::Tools::next_migrate_port($pfamily); - $migrate_uri = "tcp:${localip}:${migrate_port}"; - push @$cmd, '-incoming', $migrate_uri; + $migrate->{port} = PVE::Tools::next_migrate_port($pfamily); + $migrate->{uri} = "tcp:$migrate->{addr}:$migrate->{port}"; + push @$cmd, '-incoming', $migrate->{uri}; push @$cmd, '-S'; } elsif ($statefile eq 'unix') { # should be default for secure migrations as a ssh TCP forward # tunnel is not deterministic reliable ready and fails regurarly # to set up in time, so use UNIX socket forwards - my $socket_addr = "/run/qemu-server/$vmid.migrate"; - unlink $socket_addr; + my $migrate = $res->{migrate} = { proto => 'unix' }; + $migrate->{addr} = "/run/qemu-server/$vmid.migrate"; + unlink $migrate->{addr}; - $migrate_uri = "unix:$socket_addr"; - - push @$cmd, '-incoming', $migrate_uri; + $migrate->{uri} = "unix:$migrate->{addr}"; + push @$cmd, '-incoming', $migrate->{uri}; push @$cmd, '-S'; } elsif (-e $statefile) { @@ -5628,10 +5628,9 @@ sub vm_start_nolock { eval { PVE::QemuServer::PCI::reserve_pci_usage($pci_id_list, $vmid, undef, $pid) }; warn $@ if $@; - print "migration listens on $migrate_uri\n" if $migrate_uri; - $res->{migrate_uri} = $migrate_uri; - - if ($statefile && $statefile ne 'tcp' && $statefile ne 'unix') { + if (defined($res->{migrate})) { + print "migration listens on $res->{migrate}->{uri}\n"; + } elsif ($statefile) { eval { mon_cmd($vmid, "cont"); }; warn $@ if $@; } @@ -5646,6 +5645,7 @@ sub vm_start_nolock { my $socket_path = "/run/qemu-server/$vmid\_nbd.migrate"; mon_cmd($vmid, "nbd-server-start", addr => { type => 'unix', data => { path => $socket_path } } ); $migrate_storage_uri = "nbd:unix:$socket_path"; + $res->{migrate}->{unix_sockets} = [$socket_path]; } else { my $nodename = nodename(); my $localip = $get_migration_ip->($nodename); @@ -5663,8 +5663,6 @@ sub vm_start_nolock { $migrate_storage_uri = "nbd:${localip}:${storage_migrate_port}"; } - $res->{migrate_storage_uri} = $migrate_storage_uri; - foreach my $opt (sort keys %$nbd) { my $drivestr = $nbd->{$opt}->{drivestr}; my $volid = $nbd->{$opt}->{volid}; -- 2.30.2