From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2FB097EAC9 for ; Thu, 11 Nov 2021 12:07:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B0CE9B3C for ; Thu, 11 Nov 2021 12:07:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0CBB59AD3 for ; Thu, 11 Nov 2021 12:07:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DA08E44BBC for ; Thu, 11 Nov 2021 12:07:10 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 11 Nov 2021 12:07:05 +0100 Message-Id: <20211111110709.633855-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211111110709.633855-1-d.csapak@proxmox.com> References: <20211111110709.633855-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.225 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/5] ui: dc/Backup: never show id input field, autogenerate id X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 11:07:42 -0000 similar to pbs sync jobs Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index e33f5e27..3f250a76 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -176,24 +176,6 @@ Ext.define('PVE.dc.BackupEdit', { }); let column1 = [ - { - xtype: 'pmxDisplayEditField', - name: 'id', - fieldLabel: gettext('ID'), - renderer: Ext.htmlEncode, - fieldStyle: me.isCreate ? {} : { - 'text-overflow': 'ellipsis', - 'overflow': 'hidden', - 'white-space': 'nowrap', - }, - editConfig: { - maxLength: 20, // easier to allow more than less in the future.. - enforceMaxLength: true, - }, - vtype: 'ConfigId', - allowBlank: false, - editable: me.isCreate, - }, nodesel, storagesel, { @@ -263,6 +245,10 @@ Ext.define('PVE.dc.BackupEdit', { delete values.node; } + if (!values.id && me.isCreate) { + values.id = 'backup-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13); + } + let selMode = values.selMode; delete values.selMode; -- 2.30.2