From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DB4C37E683 for ; Wed, 10 Nov 2021 15:19:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D936B1DE92 for ; Wed, 10 Nov 2021 15:19:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E62681DE84 for ; Wed, 10 Nov 2021 15:19:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C6B0426BB for ; Wed, 10 Nov 2021 15:19:11 +0100 (CET) Date: Wed, 10 Nov 2021 15:19:10 +0100 From: Stoiko Ivanov To: Oguz Bektas Cc: Proxmox VE development discussion Message-ID: <20211110151910.2bb46160@rosa.proxmox.com> In-Reply-To: <20211110130746.1025299-1-o.bektas@proxmox.com> References: <20211110130746.1025299-1-o.bektas@proxmox.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.328 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH kernel-meta] boot-tool: fix whitespace in generated loader configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 14:19:12 -0000 Huge thanks for addressing this and directly providing a patch (and sorry for fat-fingering the indentation in the first place) as discussed off-list - I was not able to reproduce the issue (of a non-booting system) directly - so the indentation alone was not the problem. One thing that rendered my test-system unbootable was adding empty lines to /etc/kernel/cmdline (and running p-b-t refresh) - I sent a short follow-up for this. In any case - your patch works as advertised: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Wed, 10 Nov 2021 14:07:46 +0100 Oguz Bektas wrote: > issue reported in forum [0] > > seems like it came in with 2a8a4b5e37e87a0a994fe3820b015e051e6259fb > > [0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/ > > before: > ======== > $ cat /mnt/foo/loader/entries/proxmox-5.11.22-7-pve.conf > title Proxmox Virtual Environment > version 5.11.22-7-pve > options root=ZFS=rpool/ROOT/pve-1 boot=zfs iommu=pt > linux /EFI/proxmox/5.11.22-7-pve/vmlinuz-5.11.22-7-pve > initrd /EFI/proxmox/5.11.22-7-pve/initrd.img-5.11.22-7-pve > > after: > ======== > $ proxmox-boot-tool refresh > $ cat /mnt/foo/loader/entries/proxmox-5.11.22-7-pve.conf > title Proxmox Virtual Environment > version 5.11.22-7-pve > options root=ZFS=rpool/ROOT/pve-1 boot=zfs iommu=pt > linux /EFI/proxmox/5.11.22-7-pve/vmlinuz-5.11.22-7-pve > initrd /EFI/proxmox/5.11.22-7-pve/initrd.img-5.11.22-7-pve > > Signed-off-by: Oguz Bektas > --- > proxmox-boot/zz-proxmox-boot | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/proxmox-boot/zz-proxmox-boot b/proxmox-boot/zz-proxmox-boot > index 4bd63a6..52171b2 100755 > --- a/proxmox-boot/zz-proxmox-boot > +++ b/proxmox-boot/zz-proxmox-boot > @@ -140,8 +140,8 @@ copy_and_config_kernels() { > title ${LOADER_TITLE} > version ${kver} > options ${CMDLINE} > - linux /${KERNEL_ESP_DIR}/vmlinuz-${kver} > - initrd /${KERNEL_ESP_DIR}/initrd.img-${kver} > + linux /${KERNEL_ESP_DIR}/vmlinuz-${kver} > + initrd /${KERNEL_ESP_DIR}/initrd.img-${kver} > EOF > else > warn " Copying kernel ${kver}"