From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id DCF937E55E
 for <pve-devel@lists.proxmox.com>; Wed, 10 Nov 2021 15:02:58 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id CFFD41D7FF
 for <pve-devel@lists.proxmox.com>; Wed, 10 Nov 2021 15:02:58 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id A35011D7E3
 for <pve-devel@lists.proxmox.com>; Wed, 10 Nov 2021 15:02:57 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7222B426BB
 for <pve-devel@lists.proxmox.com>; Wed, 10 Nov 2021 15:02:57 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 10 Nov 2021 15:02:56 +0100
Message-Id: <20211110140256.1863209-5-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211110140256.1863209-1-d.csapak@proxmox.com>
References: <20211110140256.1863209-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.227 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager 4/4] ui: dc/Backup: add comment field
 and column
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 10 Nov 2021 14:02:58 -0000

and hide the ID column by default

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/Backup.js          | 17 ++++++++++++++++-
 www/manager6/dc/BackupJobDetail.js |  5 +++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 24fa94a6..45ee7022 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -238,6 +238,14 @@ Ext.define('PVE.dc.BackupEdit', {
 	    onlineHelp: 'chapter_vzdump',
 	    column1: column1,
 	    column2: column2,
+	    columnB: [
+		{
+		    xtype: 'proxmoxtextfield',
+		    name: 'comment',
+		    fieldLabel: gettext('Comment'),
+		    deleteEmpty: !me.isCreate,
+		},
+	    ],
 	    onGetValues: function(values) {
 		if (!values.node) {
 		    if (!me.isCreate) {
@@ -717,6 +725,7 @@ Ext.define('PVE.dc.BackupView', {
 		{
 		    header: gettext('ID'),
 		    dataIndex: 'id',
+		    hidden: true,
 		},
 		{
 		    header: gettext('Node'),
@@ -742,8 +751,14 @@ Ext.define('PVE.dc.BackupView', {
 		    dataIndex: 'storage',
 		},
 		{
-		    header: gettext('Selection'),
+		    header: gettext('Comment'),
+		    dataIndex: 'comment',
+		    renderer: Ext.htmlEncode,
 		    flex: 1,
+		},
+		{
+		    header: gettext('Selection'),
+		    flex: 2,
 		    sortable: false,
 		    dataIndex: 'vmid',
 		    renderer: PVE.Utils.render_backup_selection,
diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js
index 19b3b1a3..8300a7d2 100644
--- a/www/manager6/dc/BackupJobDetail.js
+++ b/www/manager6/dc/BackupJobDetail.js
@@ -246,6 +246,11 @@ Ext.define('PVE.dc.BackupInfo', {
     ],
 
     columnB: [
+	{
+	    xtype: 'displayfield',
+	    name: 'comment',
+	    fieldLabel: gettext('Comment'),
+	},
 	{
 	    xtype: 'label',
 	    name: 'pruneLabel',
-- 
2.30.2