From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 81F4B7C380 for ; Thu, 4 Nov 2021 15:23:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6FE1321554 for ; Thu, 4 Nov 2021 15:22:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D7A8F21549 for ; Thu, 4 Nov 2021 15:22:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CBAE246A4C for ; Thu, 4 Nov 2021 15:16:27 +0100 (CET) Date: Thu, 4 Nov 2021 15:16:26 +0100 From: Wolfgang Bumiller To: Thomas Lamprecht Cc: pve-devel@lists.proxmox.com Message-ID: <20211104141626.iys35roshf66fch2@olga.proxmox.com> References: <20211103155812.1461208-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211103155812.1461208-1-t.lamprecht@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.573 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, qemu.pm] Subject: Re: [pve-devel] [PATCH v2 0/4] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 14:23:10 -0000 I guess that's okay... for all those weirdos who don't create `.link` files to pin their network interface names in place :-P Acked-by: Wolfgang Bumiller On Wed, Nov 03, 2021 at 04:58:08PM +0100, Thomas Lamprecht wrote: > changes v1 -> v2: > * move checks into own method > * ensure forced machine is parsed so that min_version can work > * only apply on `l26` ostype > * fix test file name and comment > > v1 cover letter: > > First add a new meta property that is currently exclusively set on new > VM creation and then read-only, initially add the creation time as UNIX > epoch and the QEMU version that was installed during installation > (thought about using the one on first start but that actually does not > gives any more guarantee, so just go for simple). > > Use that information to band aid around a change regarding hotplug in > QEMU 6.1 that can affected older VMs on fresh start (migration and > rollback is covered by force-machine mechanisms as always already). > > I'm not 100% convinced of the whole thing, albeit I see some merit in > the meta property even if we do not go with the last patch, anyhow, I > proposed this off-list to Dominik (and those thing is partly his idea > too), Wolfgang, Fabian and Stefan and none of them rejected the idea nor > communicated a better/more preferred alternative, so I went for it > (still not steaming from enthusiasm though) > > Thomas Lamprecht (4): > config: add new meta property withe creation time > config: meta: also save the QEMU version installed during creation > tests: cfg2cmd: add a few q35 related tests > cfg2cmd: switch off ACPI hotplug on bridges for q35 VMs > > PVE/API2/Qemu.pm | 2 + > PVE/QemuServer.pm | 73 +++++++++++++++++++ > .../q35-linux-hostpci-multifunction.conf.cmd | 1 + > test/cfg2cmd/q35-linux-hostpci.conf.cmd | 1 + > test/cfg2cmd/q35-simple-6.0.conf | 13 ++++ > test/cfg2cmd/q35-simple-6.0.conf.cmd | 28 +++++++ > test/cfg2cmd/q35-simple-7.0.conf | 14 ++++ > test/cfg2cmd/q35-simple-7.0.conf.cmd | 28 +++++++ > test/cfg2cmd/q35-simple-pinned-6.1.conf | 13 ++++ > test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd | 28 +++++++ > test/cfg2cmd/q35-simple.conf | 13 ++++ > test/cfg2cmd/q35-simple.conf.cmd | 29 ++++++++ > 12 files changed, 243 insertions(+) > create mode 100644 test/cfg2cmd/q35-simple-6.0.conf > create mode 100644 test/cfg2cmd/q35-simple-6.0.conf.cmd > create mode 100644 test/cfg2cmd/q35-simple-7.0.conf > create mode 100644 test/cfg2cmd/q35-simple-7.0.conf.cmd > create mode 100644 test/cfg2cmd/q35-simple-pinned-6.1.conf > create mode 100644 test/cfg2cmd/q35-simple-pinned-6.1.conf.cmd > create mode 100644 test/cfg2cmd/q35-simple.conf > create mode 100644 test/cfg2cmd/q35-simple.conf.cmd > > -- > 2.30.2