From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7EEDE7B20F for ; Fri, 29 Oct 2021 13:17:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 75F8ECE92 for ; Fri, 29 Oct 2021 13:16:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 92478CE80 for ; Fri, 29 Oct 2021 13:16:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 670EB45E05 for ; Fri, 29 Oct 2021 13:16:29 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 29 Oct 2021 13:16:24 +0200 Message-Id: <20211029111624.142116-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211029111624.142116-1-f.ebner@proxmox.com> References: <20211029111624.142116-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.243 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: [pve-devel] [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 11:17:01 -0000 No functional change is intended. Signed-off-by: Fabian Ebner --- No changes from v1. Dependency bump for pve-common is needed. src/PVE/LXC.pm | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index b07d986..aed20a3 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -29,11 +29,11 @@ use PVE::Tools qw( $IPV4RE $IPV6RE ); -use PVE::RPCEnvironment; use PVE::CpuSet; use PVE::Network; use PVE::AccessControl; use PVE::ProcFSTools; +use PVE::RESTEnvironment; use PVE::Syscall qw(:fsmount); use PVE::LXC::Config; use PVE::GuestHelpers qw(safe_string_ne safe_num_ne safe_boolean_ne); @@ -2306,13 +2306,8 @@ my sub print_ct_warn_log { my $log = eval { file_get_contents($log_fn) }; return if !$log; - my $rpcenv = eval { PVE::RPCEnvironment::get() }; - - my $warn_fn = $rpcenv ? sub { $rpcenv->warn($_[0]) } : sub { print STDERR "WARN: $_[0]\n" }; - while ($log =~ /^\h*\s*(.*?)\h*$/gm) { - my $line = $1; - $warn_fn->($line); + PVE::RESTEnvironment::log_warn($1); } unlink $log_fn or warn "could not unlink '$log_fn' - $!\n"; } -- 2.30.2