From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 26C8279EE1 for ; Thu, 28 Oct 2021 13:42:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24D811F967 for ; Thu, 28 Oct 2021 13:42:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 89EF61F921 for ; Thu, 28 Oct 2021 13:41:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5D0C04695A for ; Thu, 28 Oct 2021 13:41:57 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Thu, 28 Oct 2021 13:41:46 +0200 Message-Id: <20211028114150.3245864-6-s.reiter@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211028114150.3245864-1-s.reiter@proxmox.com> References: <20211028114150.3245864-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.446 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC manager 5/9] gui: VMCPUFlagSelector: fix unknownFlags behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 11:42:00 -0000 ...and typo in name. Signed-off-by: Stefan Reiter --- www/manager6/form/VMCPUFlagSelector.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index ace3c531..a6d17930 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -14,7 +14,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { scrollable: 'y', height: 200, - unkownFlags: [], + unknownFlags: [], store: { type: 'store', @@ -59,7 +59,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { } }); - flags += me.unkownFlags.join(';'); + flags += (flags.length > 0 ? ';' : '') + me.unknownFlags.join(';'); return flags; }, @@ -70,7 +70,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { me.value = value || ''; - me.unkownFlags = []; + me.unknownFlags = []; me.getStore().queryBy(Ext.returnTrue).each(function(rec) { rec.set('state', '='); @@ -79,13 +79,13 @@ Ext.define('PVE.form.VMCPUFlagSelector', { var flags = value ? value.split(';') : []; flags.forEach(function(flag) { var sign = flag.substr(0, 1); - flag = flag.substr(1); + let flagName = flag.substr(1); - var rec = store.findRecord('flag', flag, 0, false, true, true); + var rec = store.findRecord('flag', flagName, 0, false, true, true); if (rec !== null) { rec.set('state', sign); } else { - me.unkownFlags.push(flag); + me.unknownFlags.push(flag); } }); store.reload(); -- 2.30.2