From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 24C8175586 for ; Wed, 13 Oct 2021 14:32:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2237711547 for ; Wed, 13 Oct 2021 14:32:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 635A811534 for ; Wed, 13 Oct 2021 14:31:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3C4B145DCD for ; Wed, 13 Oct 2021 14:31:59 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Wed, 13 Oct 2021 14:31:53 +0200 Message-Id: <20211013123154.1221852-2-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211013123154.1221852-1-o.bektas@proxmox.com> References: <20211013123154.1221852-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.980 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lxc.pm] Subject: [pve-devel] [PATCH v2 container 1/2] api: clone_vm: don't include snapshot properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 12:32:00 -0000 apparently this caused a weird[0] bug... when a container with a snapshot was cloned, it would take 'parent: foo' from the original container. if you add a new snapshot 'bar', and then another one 'foo', this causes the snapshots to become parents of each other (thus not parsed correctly in the tree view of GUI nor with 'pct listsnapshot CTID') we also drop these properties for VMs, so it makes sense to do the same here as well. [0]: https://forum.proxmox.com/threads/snapshots-of-one-lxc-disappeared.97711/ Signed-off-by: Oguz Bektas --- src/PVE/API2/LXC.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 1f2f1f0..05cfbad 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1512,7 +1512,12 @@ __PACKAGE__->register_method({ # Replace the 'disk' lock with a 'create' lock. $newconf->{lock} = 'create'; + # delete all snapshot related config options delete $newconf->{snapshots}; + delete $newconf->{parent}; + delete $newconf->{snaptime}; + delete $newconf->{snapstate}; + delete $newconf->{pending}; delete $newconf->{template}; if ($param->{hostname}) { -- 2.30.2