From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 532F274C2D for ; Mon, 11 Oct 2021 14:55:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A18D20D55 for ; Mon, 11 Oct 2021 14:55:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 425F320D3D for ; Mon, 11 Oct 2021 14:55:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 16B0B45CBC for ; Mon, 11 Oct 2021 14:55:28 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Mon, 11 Oct 2021 14:55:19 +0200 Message-Id: <20211011125520.1124937-3-s.reiter@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211011125520.1124937-1-s.reiter@proxmox.com> References: <20211011125520.1124937-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.517 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2021 12:55:59 -0000 and reorder the panel a bit, as otherwise I found it *very* cluttered. Signed-off-by: Stefan Reiter --- www/manager6/qemu/SystemEdit.js | 50 +++++++++++++++------------------ 1 file changed, 22 insertions(+), 28 deletions(-) diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js index 362365a9..8d178f06 100644 --- a/www/manager6/qemu/SystemEdit.js +++ b/www/manager6/qemu/SystemEdit.js @@ -69,28 +69,15 @@ Ext.define('PVE.qemu.SystemInputPanel', { comboItems: PVE.Utils.kvm_vga_driver_array(), }, { - xtype: 'proxmoxcheckbox', - name: 'agent', - uncheckedValue: 0, - defaultValue: 0, - deleteDefaultValue: true, - fieldLabel: gettext('Qemu Agent'), - }, - ], - - column2: [ - { - xtype: 'pveScsiHwSelector', - name: 'scsihw', + xtype: 'proxmoxKVComboBox', + name: 'machine', value: '__default__', - bind: { - value: '{current.scsihw}', - }, - fieldLabel: gettext('SCSI Controller'), + fieldLabel: gettext('Machine'), + comboItems: [ + ['__default__', PVE.Utils.render_qemu_machine('')], + ['q35', 'q35'], + ], }, - ], - - advancedColumn1: [ { xtype: 'pveQemuBiosSelector', name: 'bios', @@ -126,16 +113,23 @@ Ext.define('PVE.qemu.SystemInputPanel', { }, ], - advancedColumn2: [ + column2: [ { - xtype: 'proxmoxKVComboBox', - name: 'machine', + xtype: 'pveScsiHwSelector', + name: 'scsihw', value: '__default__', - fieldLabel: gettext('Machine'), - comboItems: [ - ['__default__', PVE.Utils.render_qemu_machine('')], - ['q35', 'q35'], - ], + bind: { + value: '{current.scsihw}', + }, + fieldLabel: gettext('SCSI Controller'), + }, + { + xtype: 'proxmoxcheckbox', + name: 'agent', + uncheckedValue: 0, + defaultValue: 0, + deleteDefaultValue: true, + fieldLabel: gettext('Qemu Agent'), }, { xtype: 'proxmoxcheckbox', -- 2.30.2