From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1BF1674958 for ; Mon, 11 Oct 2021 09:14:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 099951ADA5 for ; Mon, 11 Oct 2021 09:14:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 63C201AD9C for ; Mon, 11 Oct 2021 09:14:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 34A6D45C94 for ; Mon, 11 Oct 2021 09:14:27 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 11 Oct 2021 09:14:23 +0200 Message-Id: <20211011071423.11445-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.274 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] vzdump: pbs: suppress output from upload-log command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2021 07:14:58 -0000 which ended up in the backup task log and can be confusing to users: > INFO: Backup finished at 2021-10-11 08:40:38 > Result: { > "data": null > } > INFO: Backup job finished successfully For proxmox-backup-server < 2.0.11-1, there was no output for the upload-log command. Reported in the community forum: https://forum.proxmox.com/threads/backup-finishes-ok-but-data-null-info-on-finish.97740/ Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index d00be8b2..88ac11b3 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -1097,6 +1097,7 @@ sub exec_backup_task { 'upload-log', [ $pbs_snapshot_name, $task->{tmplog} ], errmsg => "uploading backup task log failed", + outfunc => sub {}, ); }; debugmsg('warn', "$@") if $@; # $@ contains already error prefix -- 2.30.2