From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A6D8E73B45 for ; Fri, 8 Oct 2021 14:52:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BCFF273AA for ; Fri, 8 Oct 2021 14:52:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CC491273A1 for ; Fri, 8 Oct 2021 14:52:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9CCC4459A1 for ; Fri, 8 Oct 2021 14:52:29 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 8 Oct 2021 14:52:26 +0200 Message-Id: <20211008125226.56551-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.275 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, manager.pm] Subject: [pve-devel] [RFC ha-manager] manage: handle edge case where a node gets stuck in 'fence' state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 12:52:30 -0000 If all services in 'fence' state are gone from a node (e.g. by removing the services) before fence_node() was successful, a node would get stuck in the 'fence' state. Avoid this by calling fence_node() if the node is in 'fence' state, regardless of service state. Reported in the community forum: https://forum.proxmox.com/threads/ha-migration-stuck-is-doing-nothing.94469/ Signed-off-by: Fabian Ebner --- Not really sure if this is worth it, because it's a hard to reach edge case, but AFAICT there is no good way to get out of being stuck. What would work is either of: * Manually correcting the node state. * Adding a service to the stuck node and triggering a fence situation. An alternative would be to keep services in 'fence' state in the manager state, even if they were removed from the config. But the approach from this patch seemed a bit more robust: for example, it will fix an already existing stuck state, rather than just avoid creating one. src/PVE/HA/Manager.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index 1c66b43..fc445b1 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -472,6 +472,14 @@ sub manage { $repeat = 1; # for faster execution } + # Avoid that a node without services in 'fence' state gets stuck in 'fence' state. + for my $node (sort keys $ns->{status}->%*) { + next if $ns->get_node_state($node) ne 'fence'; + next if defined($fenced_nodes->{$node}); + + $fenced_nodes->{$node} = $ns->fence_node($node) || 0; + } + last if !$repeat; } -- 2.30.2