From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C8402734BC for ; Thu, 7 Oct 2021 10:28:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF53216640 for ; Thu, 7 Oct 2021 10:27:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B0D8216605 for ; Thu, 7 Oct 2021 10:27:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ECDBB458D8 for ; Thu, 7 Oct 2021 10:27:27 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 7 Oct 2021 10:27:23 +0200 Message-Id: <20211007082727.1385888-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211007082727.1385888-1-d.csapak@proxmox.com> References: <20211007082727.1385888-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.309 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.pm] Subject: [pve-devel] [PATCH manager 3/7] api/backup: refactor string for all days X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2021 08:28:07 -0000 Signed-off-by: Dominik Csapak --- PVE/API2/Backup.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 3b343636..9dc3b48e 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -17,6 +17,8 @@ use PVE::VZDump::Common; use base qw(PVE::RESTHandler); +use constant ALL_DAYS => 'mon,tue,wed,thu,fri,sat,sun'; + PVE::JSONSchema::register_format('pve-day-of-week', \&verify_day_of_week); sub verify_day_of_week { my ($value, $noerr) = @_; @@ -101,7 +103,7 @@ __PACKAGE__->register_method({ type => 'string', format => 'pve-day-of-week-list', optional => 1, description => "Day of week selection.", - default => 'mon,tue,wed,thu,fri,sat,sun', + default => ALL_DAYS, }, enabled => { type => 'boolean', @@ -129,7 +131,7 @@ __PACKAGE__->register_method({ my $create_job = sub { my $data = cfs_read_file('vzdump.cron'); - $param->{dow} = 'mon,tue,wed,thu,fri,sat,sun' if !defined($param->{dow}); + $param->{dow} = ALL_DAYS if !defined($param->{dow}); $param->{enabled} = 1 if !defined($param->{enabled}); PVE::VZDump::verify_vzdump_parameters($param, 1); -- 2.30.2