From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 2EBCC733CB
 for <pve-devel@lists.proxmox.com>; Thu,  7 Oct 2021 10:27:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 21DF116656
 for <pve-devel@lists.proxmox.com>; Thu,  7 Oct 2021 10:27:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id A257C165FF
 for <pve-devel@lists.proxmox.com>; Thu,  7 Oct 2021 10:27:33 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D9F51458A8
 for <pve-devel@lists.proxmox.com>; Thu,  7 Oct 2021 10:27:27 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu,  7 Oct 2021 10:27:22 +0200
Message-Id: <20211007082727.1385888-4-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211007082727.1385888-1-d.csapak@proxmox.com>
References: <20211007082727.1385888-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.308 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager 2/7] postinst: use reload-or-restart
 instead of reload-or-try-restart
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 07 Oct 2021 08:27:38 -0000

the only difference is that reload-or-try-restart does not
do anything if the service is not started already.

on upgrade, we explicitely check if the service is enabled, and only
then do this action. so it would now start daemons that were
stopped but not disabled (which is not really valid  state anyway)

this starts new daemons (like the pvescheduler) automatically on
a package upgrade

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 debian/postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/postinst b/debian/postinst
index f6407178..7be1aa3d 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -181,7 +181,7 @@ case "$1" in
 	# modeled after code generated by dh_start
 	for unit in ${UNITS}; do
 	    if test -n "$2"; then
-		dh_action="reload-or-try-restart";
+		dh_action="reload-or-restart";
 	    else
 		dh_action="start"
 	    fi
-- 
2.30.2