From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A5C32732A9 for ; Wed, 6 Oct 2021 23:58:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95AC211737 for ; Wed, 6 Oct 2021 23:58:57 +0200 (CEST) Received: from kvmformation3.odiso.net (globalOdiso.M6Lille.odiso.net [89.248.211.242]) by firstgate.proxmox.com (Proxmox) with ESMTP id 77B4A1172C for ; Wed, 6 Oct 2021 23:58:56 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 2DCBF10C826; Wed, 6 Oct 2021 23:58:49 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Wed, 6 Oct 2021 23:58:44 +0200 Message-Id: <20211006215844.622823-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.851 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.249 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.399 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH v3 qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 21:58:57 -0000 This option don't have any impact on device itself. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 076ce59..2c63826 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4829,6 +4829,8 @@ sub vmconfig_hotplug_pending { } elsif ($opt eq 'cpulimit') { my $cpulimit = $conf->{pending}->{$opt} == 0 ? -1 : int($conf->{pending}->{$opt} * 100000); $cgroup->change_cpu_quota($cpulimit, 100000); + } elsif ($opt eq 'agent') { + vmconfig_update_agent($conf, $opt, $value); } else { die "skip\n"; # skip non-hot-pluggable options } @@ -4988,6 +4990,29 @@ sub vmconfig_update_net { } } +sub vmconfig_update_agent { + my ($conf, $opt, $value) = @_; + + die "skip\n" if !$conf->{$opt}; + + my $hotplug_options = { fstrim_cloned_disks => 1 }; + + my $old_agent = parse_guest_agent($conf); + my $agent = parse_guest_agent({$opt => $value}); + + #added/changed options + foreach my $option (keys %$agent) { + next if defined($hotplug_options->{$option}); + die "skip\n" if safe_string_ne($agent->{$option}, $old_agent->{$option}); + } + + #removed options + foreach my $option (keys %$old_agent) { + next if defined($hotplug_options->{$option}); + die "skip\n" if safe_string_ne($old_agent->{$option}, $agent->{$option}); + } +} + sub vmconfig_update_disk { my ($storecfg, $conf, $hotplug, $vmid, $opt, $value, $arch, $machine_type) = @_; -- 2.30.2