From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A2BF27212A for ; Wed, 6 Oct 2021 11:19:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 084699DD5 for ; Wed, 6 Oct 2021 11:19:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CA1A19D5E for ; Wed, 6 Oct 2021 11:18:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A2A5D45802 for ; Wed, 6 Oct 2021 11:18:58 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 6 Oct 2021 11:18:51 +0200 Message-Id: <20211006091853.82237-12-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211006091853.82237-1-f.ebner@proxmox.com> References: <20211006091853.82237-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.287 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC v2 manager 4/6] partially fix #2285: ui: ceph: allow selecting partitions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 09:19:59 -0000 For DB and WAL disks, not only partitions will show up now, but one more type of disk, that didn't show up before: Namely, GPT-partitioned disks with any partitions detected as used. It's confusing as the size shown is of the full disk, with no indication that a new partition will be appended at the end. This problem was already present before, but only affected GPT-partitioned disks where no usage on a partition was detected. Signed-off-by: Fabian Ebner --- No changes from v1. RFC, because of the weird situation with the DB/WAL disks...Even if we choose to extend the support in the back-end, it might make sense to limit what we show in the front-end. Dependency bump for widget-toolkit needed. www/manager6/ceph/OSD.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index aea38d6c..3e775606 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -38,6 +38,7 @@ Ext.define('PVE.CephCreateOsd', { name: 'dev', nodename: me.nodename, diskType: 'unused', + includePartitions: true, fieldLabel: gettext('Disk'), allowBlank: false, }, @@ -48,6 +49,7 @@ Ext.define('PVE.CephCreateOsd', { name: 'db_dev', nodename: me.nodename, diskType: 'journal_disks', + includePartitions: true, fieldLabel: gettext('DB Disk'), value: '', autoSelect: false, @@ -101,6 +103,7 @@ Ext.define('PVE.CephCreateOsd', { name: 'wal_dev', nodename: me.nodename, diskType: 'journal_disks', + includePartitions: true, fieldLabel: gettext('WAL Disk'), value: '', autoSelect: false, -- 2.30.2