From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4451571B2A for ; Tue, 5 Oct 2021 10:10:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3944724920 for ; Tue, 5 Oct 2021 10:10:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D1CDE24917 for ; Tue, 5 Oct 2021 10:09:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ABD63455F7 for ; Tue, 5 Oct 2021 10:09:59 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Tue, 5 Oct 2021 10:09:52 +0200 Message-Id: <20211005080952.369898-3-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211005080952.369898-1-o.bektas@proxmox.com> References: <20211005080952.369898-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm] Subject: [pve-devel] [PATCH v2 container 2/2] setup: drop remaining unmanaged return X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 08:10:30 -0000 not needed anymore since we have 'unmanaged' plugin, so $self->{plugin} would be 'unmanaged' and get handled by that instead of an early return. Signed-off-by: Oguz Bektas --- src/PVE/LXC/Setup.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm index cfbe02c..4e211ef 100644 --- a/src/PVE/LXC/Setup.pm +++ b/src/PVE/LXC/Setup.pm @@ -228,8 +228,6 @@ my sub generate_ssh_key { # create temporary key in hosts' /run, then read and u sub rewrite_ssh_host_keys { my ($self) = @_; - return if !$self->{plugin}; # unmanaged - my $plugin = $self->{plugin}; my $keynames = $plugin->ssh_host_key_types_to_generate(); -- 2.30.2