From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E47E8717E7 for ; Mon, 4 Oct 2021 17:29:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D34D11E079 for ; Mon, 4 Oct 2021 17:29:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B55751E05C for ; Mon, 4 Oct 2021 17:29:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 58529454EF for ; Mon, 4 Oct 2021 17:29:27 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Mon, 4 Oct 2021 17:29:19 +0200 Message-Id: <20211004152921.2839809-2-s.reiter@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211004152921.2839809-1-s.reiter@proxmox.com> References: <20211004152921.2839809-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.544 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 storage 1/3] import: don't check for 1K aligned size X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2021 15:29:58 -0000 TPM state disks on directory storages may have completely unaligned sizes, this check doesn't make sense for them. This appears to just be a (weak) safeguard and not serve an actual functional purpose, so simply get rid of it to allow migration of TPM state. Signed-off-by: Stefan Reiter --- PVE/Storage/Plugin.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 417d1fd..fab2316 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -1353,7 +1353,6 @@ sub read_common_header($) { sysread($fh, my $size, 8); $size = unpack('Q<', $size); die "import: no size found in export header, aborting.\n" if !defined($size); - die "import: got a bad size (not a multiple of 1K), aborting.\n" if ($size&1023); # Size is in bytes! return $size; } -- 2.30.2