From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 082596D6F1 for ; Tue, 28 Sep 2021 13:40:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EC8ADD25 for ; Tue, 28 Sep 2021 13:40:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9158DCAB for ; Tue, 28 Sep 2021 13:40:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5DF1E44B22 for ; Tue, 28 Sep 2021 13:40:05 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 28 Sep 2021 13:39:45 +0200 Message-Id: <20210928114001.164081-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210928114001.164081-1-f.ebner@proxmox.com> References: <20210928114001.164081-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.312 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [diskmanage.pm] Subject: [pve-devel] [PATCH storage 05/10] diskmanage: don't set usage for unused partitions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 11:40:50 -0000 The disk type is already 'partition' so there's no additional information here. And it would need to serve as a code-word for unused partitions. The cleaner approach is to not set the usage. Signed-off-by: Fabian Ebner --- Was not a smart decision back then...If this is considered a breaking change for the disk list API call, I'll go for a different approach of course, but AFAICS it would be one of: 1. Keep usage 'partition', but also return the unused partitions when 'include-partitions=1,type=unused', and have disk_is_used not complain about usage 'partition'. 2. Add a new type filter/extend it so it can handle multiple types, i.e. type=unused,partition. 3. Request all disks in the frontend and filter there. PVE/Diskmanage.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 5614e40..7aad707 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -647,7 +647,7 @@ sub get_disks { # for devices, this check is done explicitly later return 'Device Mapper' if !dir_is_empty("$sysdir/holders"); - return 'partition'; + return; # unused partition }; my $collect_ceph_info = sub { @@ -716,7 +716,6 @@ sub get_disks { my $used = $determine_usage->($devpath, $sysdir, 0); if (!$include_partitions) { foreach my $part (sort keys %{$partitions}) { - next if $partitions->{$part}->{used} eq 'partition'; $used //= $partitions->{$part}->{used}; } } else { -- 2.30.2