From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1898B6D788 for ; Tue, 28 Sep 2021 13:40:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 38A3CDEFA for ; Tue, 28 Sep 2021 13:40:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A9582DCC6 for ; Tue, 28 Sep 2021 13:40:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7DED541815 for ; Tue, 28 Sep 2021 13:40:06 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 28 Sep 2021 13:39:57 +0200 Message-Id: <20210928114001.164081-18-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210928114001.164081-1-f.ebner@proxmox.com> References: <20210928114001.164081-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.308 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [osd.pm] Subject: [pve-devel] [RFC manager 5/9] partially fix #2285: api: ceph: create osd: allow using partitions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 11:40:50 -0000 Note that this does not only allow partitions to be used, but for DB and WAL disks, one more type of disk, that wasn't allowed before. Namely, GPT-partitioned disks with any partitions detected as used. The reason is get_disks' behavior: * Without $include_partitions=1, the disk will have the same usage as it's first used partition, and thus wasn't allowed. (Except in the case that usage was LVM, where the check was bypassed, but luckily OSD creation just failed later because no Ceph volume group would be detected). * With $include_partitions=1, the disk will have usage 'partitions' and thus be allowed. Signed-off-by: Fabian Ebner --- RFC, because of the weird situation with the DB/WAL disks... Dependency bump for pve-storage is needed to actually make it work, because previously it wasn't supported to pass along partitions as elements of the first argument. PVE/API2/Ceph/OSD.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 028b37d0..c511f315 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -346,7 +346,7 @@ __PACKAGE__->register_method ({ # test disk requirements early my $devlist = [ map { $_->{name} } values %$devs ]; - my $disklist = PVE::Diskmanage::get_disks($devlist, 1); + my $disklist = PVE::Diskmanage::get_disks($devlist, 1, 1); $test_disk_requirements->($disklist); # get necessary ceph infos @@ -451,7 +451,7 @@ __PACKAGE__->register_method ({ PVE::Diskmanage::locked_disk_action(sub { # update disklist and re-test requirements - $disklist = PVE::Diskmanage::get_disks($devlist, 1); + $disklist = PVE::Diskmanage::get_disks($devlist, 1, 1); $test_disk_requirements->($disklist); my $dev_class = $param->{'crush-device-class'}; -- 2.30.2