From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4A8E16D67B for ; Tue, 28 Sep 2021 13:40:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 482C1DD0F for ; Tue, 28 Sep 2021 13:40:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3656ADC91 for ; Tue, 28 Sep 2021 13:40:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0F11B43A85 for ; Tue, 28 Sep 2021 13:40:05 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 28 Sep 2021 13:39:40 +0200 Message-Id: <20210928114001.164081-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.313 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [directory.pm, lvm.pm, zfs.pm, osd.pm, tools.pm, lvmthin.pm, disks.pm, diskmanage.pm] Subject: [pve-devel] [PATCH-SERIES storage/widget-toolkit/manager] disk creation and wiping improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 11:40:08 -0000 which also fixes the remaining parts of #2285, i.e. extending the diskmanage module and creation to support partitions. The series consists of: Tighten the checks in the disk creation paths by re-doing them after forking/locking. Work around a udev bug[0] leading to outdated device info from lsblk, by explicitly calling udevadm trigger in the appropriate places. Add support for partitions for the disk creation paths (both back-end and UI). Also change the partition type in the appropriate places as that information is used when querying disk info. [0]: https://github.com/systemd/systemd/issues/18525 Ultimately, pve-manager depends on both pve-storage and proxmox-widget-toolkit, but many things can be applied independently. pve-storage: Fabian Ebner (10): api: disks: create: re-check disk after fork/lock api: disk: work around udev bug to ensure its database is updated diskmanage: add change_parttype helper diskmanage: wipe blockdev: also change partition type diskmanage: don't set usage for unused partitions api: disks: initgpt: explicitly abort for partitions diskmanage: allow partitions for get_udev_info diskmanage: allow passing partitions to get_disks partially fix #2285: api: disks: allow partitions for creation paths api: disks: create: set correct partition type PVE/API2/Disks.pm | 12 +++++++- PVE/API2/Disks/Directory.pm | 37 ++++++++++++++++------- PVE/API2/Disks/LVM.pm | 15 +++++++++- PVE/API2/Disks/LVMThin.pm | 13 ++++++++ PVE/API2/Disks/ZFS.pm | 36 ++++++++++++++++++++-- PVE/Diskmanage.pm | 60 +++++++++++++++++++++++++++++-------- 6 files changed, 145 insertions(+), 28 deletions(-) proxmox-widget-toolkit: Fabian Ebner (2): (multi) disk selector: allow requesting partitions too disk list: allow wiping individual partitions src/form/DiskSelector.js | 7 +++++++ src/form/MultiDiskSelector.js | 22 +++++++++++++++++----- src/panel/DiskList.js | 8 -------- 3 files changed, 24 insertions(+), 13 deletions(-) pve-manager: Fabian Ebner (9): api: ceph: create osd: re-check disk requirements after fork/lock api: check: create osd: use wipe_blockdev from the Diskmanage package api: ceph: create osd: work around udev bug api: ceph: create osd: set correct parttype for DB/WAL partially fix #2285: api: ceph: create osd: allow using partitions api: ceph: create osd: set correct partition type partially fix #2285: ui: ceph: allow selecting partitions ui: zfs create: switch to using widget-toolkit's multiDiskSelector partially fix #2285: ui: disk create: allow selecting partitions PVE/API2/Ceph/OSD.pm | 112 +++++++++++++++++++++++++-------- PVE/Ceph/Tools.pm | 23 ------- www/manager6/ceph/OSD.js | 3 + www/manager6/node/Directory.js | 1 + www/manager6/node/LVM.js | 1 + www/manager6/node/LVMThin.js | 1 + www/manager6/node/ZFS.js | 81 ++---------------------- 7 files changed, 96 insertions(+), 126 deletions(-) -- 2.30.2