From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 631686BC26 for ; Tue, 21 Sep 2021 13:22:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12BD1D63E for ; Tue, 21 Sep 2021 13:22:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 00517D611 for ; Tue, 21 Sep 2021 13:22:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CECF7448B9 for ; Tue, 21 Sep 2021 13:22:11 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 21 Sep 2021 13:22:05 +0200 Message-Id: <20210921112208.48084-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210921112208.48084-1-f.ebner@proxmox.com> References: <20210921112208.48084-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.321 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager 1/4] ui: storage selector: only check for nodename before loading storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2021 11:22:43 -0000 but allow an empty nodename to be set. This is in preparation for allowing a cluster view as well, where an empty node name will indicate that no node is selected. Since the reloadStorageList function still returns early if there is no nodename, this should not lead to any issues. Signed-off-by: Fabian Ebner --- New in v2. www/manager6/form/StorageSelector.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/form/StorageSelector.js b/www/manager6/form/StorageSelector.js index 631eb378..bb56f159 100644 --- a/www/manager6/form/StorageSelector.js +++ b/www/manager6/form/StorageSelector.js @@ -74,7 +74,9 @@ Ext.define('PVE.form.StorageSelector', { setNodename: function(nodename) { var me = this; - if (!nodename || me.nodename === nodename) { + nodename = nodename || ''; + + if (me.nodename === nodename) { return; } @@ -103,9 +105,7 @@ Ext.define('PVE.form.StorageSelector', { me.callParent(); - if (nodename) { - me.setNodename(nodename); - } + me.setNodename(nodename); }, }, function() { Ext.define('pve-storage-status', { -- 2.30.2