From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.reiter@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 4D54D6B2F3
 for <pve-devel@lists.proxmox.com>; Mon, 20 Sep 2021 10:56:01 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 3EAFC1DFE5
 for <pve-devel@lists.proxmox.com>; Mon, 20 Sep 2021 10:56:01 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id BD4AA1DFDA
 for <pve-devel@lists.proxmox.com>; Mon, 20 Sep 2021 10:56:00 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 71479446EB
 for <pve-devel@lists.proxmox.com>; Mon, 20 Sep 2021 10:56:00 +0200 (CEST)
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 20 Sep 2021 10:55:51 +0200
Message-Id: <20210920085551.48298-1-s.reiter@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.563 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager] fix #3629: ui: rng: increase default
 ratelimit to 2048 B/s
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 20 Sep 2021 08:56:01 -0000

FreeBSD 13 VMs will bug out and consume loads of idle CPU time if the
ratelimit is 1024 B/s or lower. Increasing to 2048 fixes the issue,
confirmed experimentally, and doesn't seem much worse as a default.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---

On the one hand this *really* sounds like a FreeBSD bug to me, even reading
through their bugtracker linked from the report in ours.

But on the other, 2048 doesn't sound much worse as a limit either, and since
this appears to be a rather new bug I think it's enough to change it in the GUI
and avoid any hassle with API default changes.

An "ostype" for BSDs might be nice too I suppose. Not sure "Other" would cover
this, I personally use "Linux" for my BSD VMs...

 www/manager6/qemu/RNGEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/RNGEdit.js b/www/manager6/qemu/RNGEdit.js
index e34e2c08..84fdf585 100644
--- a/www/manager6/qemu/RNGEdit.js
+++ b/www/manager6/qemu/RNGEdit.js
@@ -63,7 +63,7 @@ Ext.define('PVE.qemu.RNGInputPanel', {
 	name: 'max_bytes',
 	minValue: 0,
 	step: 1,
-	value: 1024,
+	value: 2048,
 	fieldLabel: gettext('Limit (Bytes/Period)'),
 	labelWidth: 130,
 	emptyText: gettext('unlimited'),
-- 
2.30.2