From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A8C97686E6 for ; Thu, 9 Sep 2021 16:36:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9698EA27C for ; Thu, 9 Sep 2021 16:36:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 05B5FA271 for ; Thu, 9 Sep 2021 16:36:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C6C5A44660 for ; Thu, 9 Sep 2021 16:36:20 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 9 Sep 2021 16:36:19 +0200 Message-Id: <20210909143619.2706696-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.420 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: improve ACME edit/apply button visibilty X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 14:36:52 -0000 multiple users were confused[0], as they did not interpret the 'icon only' in the toolbar as a button (and it did not help that we prevented the cursor to change) to improve it, make the button a normal one again, and add some text for context (this is more inline what we do elsewhere in toolbars) 0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902 Signed-off-by: Dominik Csapak --- www/manager6/node/ACME.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index cfe9cc12..635787f6 100644 --- a/www/manager6/node/ACME.js +++ b/www/manager6/node/ACME.js @@ -365,6 +365,7 @@ Ext.define('PVE.node.ACME', { formulas: { canOrder: (get) => !!get('account') && get('domaincount') > 0, editBtnIcon: (get) => 'fa black fa-' + (get('accountEditable') ? 'check' : 'pencil'), + editBtnText: (get) => get('accountEditable') ? gettext('Apply') : gettext('Edit'), accountTextHidden: (get) => get('accountEditable') || !get('accountsAvailable'), accountValueHidden: (get) => !get('accountEditable') || !get('accountsAvailable'), }, @@ -606,10 +607,9 @@ Ext.define('PVE.node.ACME', { { xtype: 'button', iconCls: 'fa black fa-pencil', - baseCls: 'x-plain', - userCls: 'pointer', bind: { iconCls: '{editBtnIcon}', + text: '{editBtnText}', hidden: '{!accountsAvailable}', }, handler: 'toggleEditAccount', -- 2.30.2