From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 011AD6DAAC for ; Wed, 18 Aug 2021 10:51:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF8BC9DD5 for ; Wed, 18 Aug 2021 10:50:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CEDA29DC9 for ; Wed, 18 Aug 2021 10:50:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A522343431; Wed, 18 Aug 2021 10:50:53 +0200 (CEST) Date: Wed, 18 Aug 2021 10:50:52 +0200 From: Wolfgang Bumiller To: Constantin Herold Cc: pve-devel@lists.proxmox.com Message-ID: <20210818085052.444foudkjuorba7c@olga.proxmox.com> References: <20210817153434.1983-1-proxmox8914@herold.me> <20210817153434.1983-2-proxmox8914@herold.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817153434.1983-2-proxmox8914@herold.me> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.628 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [memory.pm] Subject: [pve-devel] applied: [PATCH v2 qemu-server 2/2] fix #3581: pass size via argument for memory-backend-ram qmp call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2021 08:51:28 -0000 applied, thanks For the record though, I didn't mean adding a cover letter, as that won't appear in the git history, I meant including the info in the commit message of the patch itself ;-) (There's a bug number associated with it though containing the info, so that's fine.) On Tue, Aug 17, 2021 at 05:34:34PM +0200, Constantin Herold wrote: > Signed-off-by: Constantin Herold > --- > PVE/QemuServer/Memory.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm > index f3e15f1..a41f5ae 100644 > --- a/PVE/QemuServer/Memory.pm > +++ b/PVE/QemuServer/Memory.pm > @@ -143,8 +143,7 @@ sub qemu_memory_hotplug { > my $hugepages_host_topology = hugepages_host_topology(); > hugepages_allocate($hugepages_topology, $hugepages_host_topology); > > - eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-file", id => "mem-$name", props => { > - size => int($dimm_size*1024*1024), 'mem-path' => $path, share => JSON::true, prealloc => JSON::true } ); }; > + eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-file", id => "mem-$name", size => int($dimm_size*1024*1024), 'mem-path' => $path, share => JSON::true, prealloc => JSON::true ) }; > if (my $err = $@) { > hugepages_reset($hugepages_host_topology); > die $err; > @@ -155,7 +154,7 @@ sub qemu_memory_hotplug { > eval { hugepages_update_locked($code); }; > > } else { > - eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", props => { size => int($dimm_size*1024*1024) } ) }; > + eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", size => int($dimm_size*1024*1024) ) }; > } > > if (my $err = $@) { > -- > 2.23.0