From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 78CEE6D8A2 for ; Tue, 17 Aug 2021 15:27:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6908A217E8 for ; Tue, 17 Aug 2021 15:27:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 598B6217DA for ; Tue, 17 Aug 2021 15:27:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 23233433F0; Tue, 17 Aug 2021 15:26:59 +0200 (CEST) Date: Tue, 17 Aug 2021 15:21:48 +0200 From: Wolfgang Bumiller To: Constantin Herold Cc: pve-devel@lists.proxmox.com Message-ID: <20210817132148.b5zjoct22ccm4ste@olga.proxmox.com> References: <20210812181642.1818-1-proxmox8914@herold.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210812181642.1818-1-proxmox8914@herold.me> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.635 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [memory.pm] Subject: Re: [pve-devel] [PATCH qemu-server] fix #3581: pass size via argument for memory-backend-ram qmp call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2021 13:27:09 -0000 Hi, On Thu, Aug 12, 2021 at 08:16:42PM +0200, Constantin Herold wrote: > Signed-off-by: Constantin Herold > --- > PVE/QemuServer/Memory.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm > index f3e15f1..e34727f 100644 > --- a/PVE/QemuServer/Memory.pm > +++ b/PVE/QemuServer/Memory.pm > @@ -155,7 +155,7 @@ sub qemu_memory_hotplug { > eval { hugepages_update_locked($code); }; > > } else { > - eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", props => { size => int($dimm_size*1024*1024) } ) }; > + eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", size => int($dimm_size*1024*1024) ) }; Looks fine. There's another `object-add` command a few lines higher up which also still uses `props` and needs to be changed in the same way. Care to include it in a v2? It would also be nice to include the cause in the commit message, something like: `props` was deprecated with qemu 5.0 and removed in qemu 6.0. The commands are now generally flattened.