From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 022D96CF6F for ; Thu, 12 Aug 2021 13:01:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 005F92208E for ; Thu, 12 Aug 2021 13:01:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 867F821FEE for ; Thu, 12 Aug 2021 13:01:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 536184330C for ; Thu, 12 Aug 2021 13:01:18 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 12 Aug 2021 13:01:08 +0200 Message-Id: <20210812110111.73883-10-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210812110111.73883-1-f.ebner@proxmox.com> References: <20210812110111.73883-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.414 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 guest-common 4/7] replication: remove unused variable and style fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 11:01:31 -0000 Signed-off-by: Fabian Ebner --- src/PVE/Replication.pm | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index 3da79be..83fc642 100644 --- a/src/PVE/Replication.pm +++ b/src/PVE/Replication.pm @@ -36,18 +36,25 @@ sub find_common_replication_snapshot { # test if we have a replication_ snapshot from last sync # and remove all other/stale replication snapshots - my $last_snapshots = prepare( - $storecfg, $volumes, $jobid, $last_sync, $parent_snapname, $logfunc); + my $last_snapshots = + prepare($storecfg, $volumes, $jobid, $last_sync, $parent_snapname, $logfunc); # prepare remote side my $remote_snapshots = remote_prepare_local_job( - $ssh_info, $jobid, $vmid, $volumes, $storeid_list, $last_sync, $parent_snapname, 0, $logfunc); + $ssh_info, + $jobid, + $vmid, + $volumes, + $storeid_list, + $last_sync, + $parent_snapname, + 0, + $logfunc, + ); my $base_snapshots = {}; foreach my $volid (@$volumes) { - my $base_snapname; - if (defined($last_snapshots->{$volid}) && defined($remote_snapshots->{$volid})) { if ($last_snapshots->{$volid}->{$last_sync_snapname} && $remote_snapshots->{$volid}->{$last_sync_snapname}) { -- 2.30.2