From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 292C46CB71 for ; Tue, 10 Aug 2021 15:27:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02557FC9C for ; Tue, 10 Aug 2021 15:27:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D855AFC90 for ; Tue, 10 Aug 2021 15:27:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A28AE431AE for ; Tue, 10 Aug 2021 15:27:27 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Tue, 10 Aug 2021 15:27:26 +0200 Message-Id: <20210810132726.1209136-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.315 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH RFC manager] ui: ceph install wizard: fix config exists note position X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Aug 2021 13:27:59 -0000 During the Ceph installation, in the configuration step, a note is shown if there already is a Ceph configuration present. This notification should be in the center of the wizard but is currently barely visible. ExtJS is having trouble calculating the position and the result is that the note is placed almost out of the visible area. Setting a fixed height helps ExtJS calculate the vertical position. Changing from the 'beforeshow' listener to the 'afterrender' one helps for the horizontal position. Signed-off-by: Aaron Lauterer --- This feels quite hacky, hence the RFC so we can discuss a better approach that I am not aware of yet. www/manager6/ceph/CephInstallWizard.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index fc99029e..59458b0d 100644 --- a/www/manager6/ceph/CephInstallWizard.js +++ b/www/manager6/ceph/CephInstallWizard.js @@ -337,6 +337,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { xtype: 'inputpanel', title: gettext('Configuration'), onlineHelp: 'chapter_pveceph', + height: 300, cbind: { nodename: '{nodename}', }, @@ -350,7 +351,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { activate: function() { this.up('pveCephInstallWizard').down('#submit').setText(gettext('Next')); }, - beforeshow: function() { + afterrender: function() { if (this.up('pveCephInstallWizard').getViewModel().get('configuration')) { this.mask("Configuration already initialized", ['pve-static-mask']); } else { -- 2.30.2