From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D95C36C570 for ; Fri, 6 Aug 2021 17:44:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF5CA102A2 for ; Fri, 6 Aug 2021 17:44:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5687E10279 for ; Fri, 6 Aug 2021 17:44:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 20CB542F7B for ; Fri, 6 Aug 2021 17:44:43 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Fri, 6 Aug 2021 17:44:26 +0200 Message-Id: <20210806154429.1675997-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [acme.pm, acme.sh] URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [acme.sh] Subject: [pve-devel] [PATCH proxmox-acme 0/3] update acme.sh and fix #3536 and #3546 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Aug 2021 15:44:44 -0000 This patchset started out as attempt to add comfortable proxy-handling to our acme client(s) and to address #3536 and #3546, but in it's current form only fixes the two issues. patch 1/3 is independent of the others and enables users to interact with an ACME provider via proxy on PVE on the commandline (by exporting the https_proxy environment variable). the remaining patches simply update the acme.sh submodule, add the 2 new dns-plugins to our schema.json file and and port over retrying GET and POST requests from acme.sh. Tested on my PVE-node with a domain of mine and the powerdns api: * setting https_proxy (and having a squid configured on a guest) does not cause the `pvenode acme cert renew -force` to abort due to taint-checks * the content type of the PATCH requests is application/json insted of application/x-www-form-urlencoded Stoiko Ivanov (3): acme client: fix #3536 untaint data returned from acme server update to acme.sh dns plugins to 3.0.0 plugin-caller: pull in changes from upstream 3.0.0 src/Makefile | 2 ++ src/PVE/ACME.pm | 12 +++++-- src/acme.sh | 2 +- src/dns-challenge-schema.json | 2 ++ src/proxmox-acme | 62 +++++++++++++++++++++++++++++++++-- 5 files changed, 75 insertions(+), 5 deletions(-) -- 2.30.2