From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0C1296C2FC for ; Fri, 6 Aug 2021 10:59:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF1EFB50E for ; Fri, 6 Aug 2021 10:59:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5F3B0B4F0 for ; Fri, 6 Aug 2021 10:59:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28E3A42EF9 for ; Fri, 6 Aug 2021 10:59:31 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 6 Aug 2021 10:59:27 +0200 Message-Id: <20210806085927.31277-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.425 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC/PATCH manager] ui: lxc options: disable features edit as non-root when container is privileged X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Aug 2021 08:59:38 -0000 The backend won't allow any edits in this case, so better just disable the edit button altogether. Signed-off-by: Fabian Ebner --- www/manager6/lxc/Options.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index f2661dfc..12b0fe12 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -174,7 +174,11 @@ Ext.define('PVE.lxc.Options', { var pending = rec.data.delete || me.hasPendingChanges(key); var rowdef = rows[key]; - edit_btn.setDisabled(!rowdef.editor); + let unprivileged = me.getStore().getById('unprivileged').data.value; + let nonRootPrivFeatures = + Proxmox.UserName !== 'root@pam' && key === 'features' && !unprivileged; + + edit_btn.setDisabled(!rowdef.editor || nonRootPrivFeatures); revert_btn.setDisabled(!pending); }; -- 2.30.2