From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 321486BD82 for ; Thu, 5 Aug 2021 12:31:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1BE5D29924 for ; Thu, 5 Aug 2021 12:31:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5E9682991A for ; Thu, 5 Aug 2021 12:31:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1E3A642DEA for ; Thu, 5 Aug 2021 12:31:36 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 5 Aug 2021 12:31:35 +0200 Message-Id: <20210805103135.1287114-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.471 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] panel/RRDCharts: enable scrolling for RRDCharts on touchscreens X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 10:31:37 -0000 quote from extjs docs (AbstractChart.js): If you do have a chart inside a scrollable view, even if it has no interactions, you have to set its touchAction config to the following: touchAction: { panX: true, panY: true } Otherwise, if a touch action started on a chart, a swipe will not scroll the view. Since we have RRDCharts always in a scrollable view, and it does not seem to hurt non-touchscreens, enable it by default so that users on touchscreens can scroll it. Reported by users in the forum: https://forum.proxmox.com/threads/minor-but-annoying-ipad-swipe-bug.93686 Signed-off-by: Dominik Csapak --- src/panel/RRDChart.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js index d63170e..41533ea 100644 --- a/src/panel/RRDChart.js +++ b/src/panel/RRDChart.js @@ -155,6 +155,11 @@ Ext.define('Proxmox.widget.RRDChart', { }, }, + touchAction: { + panX: true, + panY: true, + }, + constructor: function(config) { let me = this; -- 2.30.2