From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 903BF6B9AC for ; Thu, 5 Aug 2021 09:21:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EEEE26A2D for ; Thu, 5 Aug 2021 09:20:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 828ED269A3 for ; Thu, 5 Aug 2021 09:20:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0175D42E16 for ; Thu, 5 Aug 2021 09:20:03 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 5 Aug 2021 09:19:52 +0200 Message-Id: <20210805071958.4402-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.419 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment T_SPF_HELO_TEMPERROR 0.01 SPF: test of HELO record failed (temperror) T_SPF_TEMPERROR 0.01 SPF: test of record failed (temperror) Subject: [pve-devel] [PATCH-SERIES guest-common/qemu-server/container] activate storages for snapshot operations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 07:21:26 -0000 to make it work when the storage is just not active yet, and have early errors when the storage cannot be activated. Also prohibits snapshot operations when an involved storage is disabled. Both qemu-server and pve-container build-depend upon pve-guest-common for the added tests. pve-guest-common: Fabian Ebner (2): config: remove unused variable config: activate affected storages for snapshot operations src/PVE/AbstractConfig.pm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) qemu-server: Fabian Ebner (1): snapshot: implement __snapshot_activate_storages PVE/QemuConfig.pm | 19 +++++++++++ .../create/qemu-server/303.conf | 13 +++++++ .../delete/qemu-server/204.conf | 33 ++++++++++++++++++ .../rollback/qemu-server/303.conf | 34 +++++++++++++++++++ .../create/qemu-server/303.conf | 13 +++++++ .../delete/qemu-server/204.conf | 33 ++++++++++++++++++ .../rollback/qemu-server/303.conf | 34 +++++++++++++++++++ test/snapshot-test.pm | 32 +++++++++++++++++ 8 files changed, 211 insertions(+) create mode 100644 test/snapshot-expected/create/qemu-server/303.conf create mode 100644 test/snapshot-expected/delete/qemu-server/204.conf create mode 100644 test/snapshot-expected/rollback/qemu-server/303.conf create mode 100644 test/snapshot-input/create/qemu-server/303.conf create mode 100644 test/snapshot-input/delete/qemu-server/204.conf create mode 100644 test/snapshot-input/rollback/qemu-server/303.conf pve-container: Fabian Ebner (3): config: snapshot_delete_remove_drive: check for parsed value config: parse_volume: don't die when noerr is set snapshot: implement __snapshot_activate_storages src/PVE/LXC/Config.pm | 25 +++++++++++++-- .../snapshot-expected/create/lxc/204.conf | 10 ++++++ .../snapshot-expected/delete/lxc/204.conf | 25 +++++++++++++++ .../snapshot-expected/rollback/lxc/209.conf | 29 +++++++++++++++++ src/test/snapshot-input/create/lxc/204.conf | 10 ++++++ src/test/snapshot-input/delete/lxc/204.conf | 25 +++++++++++++++ src/test/snapshot-input/rollback/lxc/209.conf | 29 +++++++++++++++++ src/test/snapshot-test.pm | 32 +++++++++++++++++++ 8 files changed, 183 insertions(+), 2 deletions(-) create mode 100644 src/test/snapshot-expected/create/lxc/204.conf create mode 100644 src/test/snapshot-expected/delete/lxc/204.conf create mode 100644 src/test/snapshot-expected/rollback/lxc/209.conf create mode 100644 src/test/snapshot-input/create/lxc/204.conf create mode 100644 src/test/snapshot-input/delete/lxc/204.conf create mode 100644 src/test/snapshot-input/rollback/lxc/209.conf -- 2.30.2