From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AE67E77533 for ; Tue, 20 Jul 2021 14:09:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C5C29891 for ; Tue, 20 Jul 2021 14:08:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 98E759884 for ; Tue, 20 Jul 2021 14:08:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6B6BE40523 for ; Tue, 20 Jul 2021 14:08:49 +0200 (CEST) Date: Tue, 20 Jul 2021 14:08:48 +0200 From: Wolfgang Bumiller To: Thomas Lamprecht Cc: Oguz Bektas , Proxmox VE development discussion Message-ID: <20210720120848.jt6utnuojtn2ygya@wobu-vie.proxmox.com> References: <20210714095151.138084-1-o.bektas@proxmox.com> <20210720114059.p5k32l5jap3nudz3@wobu-vie.proxmox.com> <84bdf0fe-783e-1ed8-9fa9-70b817ea5221@proxmox.com> <95dc2d98-ec11-e8c9-1761-9fe91d18af1a@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <95dc2d98-ec11-e8c9-1761-9fe91d18af1a@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.666 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 12:09:20 -0000 On Tue, Jul 20, 2021 at 01:59:45PM +0200, Thomas Lamprecht wrote: > or we can avoid further hacks, separate the plugin ABI in an actual "interface only" > module which base and a new unmanaged plugin depends on, so that we can actually drop > that special case and with it all the `return if !$self->{plugin}; # unmanaged` stanzas > completely... sounds good to me 👍