From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C1FD77014 for ; Mon, 19 Jul 2021 15:08:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20FEC27084 for ; Mon, 19 Jul 2021 15:08:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B6F992707A for ; Mon, 19 Jul 2021 15:08:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 80BCF42351 for ; Mon, 19 Jul 2021 15:08:16 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Mon, 19 Jul 2021 15:07:54 +0200 Message-Id: <20210719130754.1011034-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.436 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager] vzdump: allow backups from plugins X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 13:08:20 -0000 remove type check for the specific plugins, instead we can deduce it from the supported content type in config (this can only be set on storages that declare to support backups). should also work with external storage plugins. Signed-off-by: Oguz Bektas --- v1->v2: * remove type check instead of adding btrfs to it PVE/VZDump.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 46cb9e6d..b671ab19 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -100,9 +100,6 @@ sub storage_info { my $scfg = PVE::Storage::storage_config($cfg, $storage); my $type = $scfg->{type}; - die "can't use storage type '$type' for backup\n" - if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs' - || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs')); die "can't use storage '$storage' for backups - wrong content type\n" if (!$scfg->{content}->{backup}); -- 2.30.2