From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D564776A2F for ; Fri, 16 Jul 2021 15:43:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D1D2511762 for ; Fri, 16 Jul 2021 15:43:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D05A711759 for ; Fri, 16 Jul 2021 15:43:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6CFD42152 for ; Fri, 16 Jul 2021 15:43:22 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Fri, 16 Jul 2021 15:43:05 +0200 Message-Id: <20210716134305.3729415-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.385 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [acme.sh] Subject: [pve-devel] [PATCH proxmox-acme] plugin-caller: make no-ops always successful X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 13:43:23 -0000 proxmox-acme is used to call the dns-plugins from acme.sh and has the config editing (saving/clearing) turned int no-ops. bash's `return` statement w/o argument returns the value of the last executed command (the one before our no-op method was called) (see `help return` in bash). This leads to unexpected behavior in some plugins, which call one of the methods as last statement join the next step with `&&`. tested bash behavior with: ``` foo() { return; }; if [ -z 'x' ]; then :; else foo ; fi; echo $? ``` reported in our community-forum: https://forum.proxmox.com/threads/pmg-acme-dns-with-cyon-failing-to-issue-certificate.92762 Signed-off-by: Stoiko Ivanov --- src/proxmox-acme | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/proxmox-acme b/src/proxmox-acme index 4d249a7..f228a0b 100644 --- a/src/proxmox-acme +++ b/src/proxmox-acme @@ -495,7 +495,7 @@ __red() { } _log() { - return + return 0 } _info() { @@ -526,11 +526,11 @@ _readaccountconf_mutable() { # no-ops: _clearaccountconf() { - return + return 0 } _cleardomainconf() { - return + return 0 } _debug() { @@ -562,23 +562,23 @@ _secure_debug3() { } _saveaccountconf() { - return + return 0 } _saveaccountconf_mutable() { - return + return 0 } _save_conf() { - return + return 0 } _savedomainconf() { - return + return 0 } _source_plugin_config() { - return + return 0 } # Proxmox implementation to inject the DNSAPI variables -- 2.30.2