From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 38517769EB for ; Fri, 16 Jul 2021 15:28:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C3A011641 for ; Fri, 16 Jul 2021 15:27:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0CEAB11638 for ; Fri, 16 Jul 2021 15:27:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5F1454200F for ; Fri, 16 Jul 2021 15:27:57 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 16 Jul 2021 15:27:53 +0200 Message-Id: <20210716132753.102535-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.340 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v4 manager] api: apt: repos: fix interfacing with perlmod X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 13:28:29 -0000 Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with the "enabled" option being a string here (in PMG I was), but be on the safe side and coerce there too. Otherwise it might get triggered by a future, completely unrelated change further up in the API call handling. Signed-off-by: Fabian Ebner --- Changes from v3: * shorter/cleaner code, but now there's no good reason for the comment anymore, because it's arguably the better code even without the perlmod limitation. But I do have a reproducer, so hopefully the issue can be fixed in perlmod before somebody else runs into it. PVE/API2/APT.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index bd60db33..ec9503de 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -750,13 +750,14 @@ __PACKAGE__->register_method({ code => sub { my ($param) = @_; - my $options = { - enabled => $param->{enabled}, - }; + my $options = {}; + + my $enabled = $param->{enabled}; + $options->{enabled} = int($enabled) if defined($enabled); PVE::RS::APT::Repositories::change_repository( $param->{path}, - $param->{index}, + int($param->{index}), $options, $param->{digest} ); -- 2.30.2