From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 74DFA762CE for ; Thu, 15 Jul 2021 08:47:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67B2D1AB6B for ; Thu, 15 Jul 2021 08:47:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E85531AB59 for ; Thu, 15 Jul 2021 08:47:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B5A0341B68 for ; Thu, 15 Jul 2021 08:47:32 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 15 Jul 2021 08:47:29 +0200 Message-Id: <20210715064729.9834-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.350 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [apt.pm] Subject: [pve-devel] [PATCH manager] api: apt: repos: fix interfacing with perlmod X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 06:47:33 -0000 Using pvesh create /nodes/pve701/apt/repositories --path "/etc/apt/sources.list" --index 0 --enabled 1 reliably leads to error: invalid type: string "0", expected usize Coerce to int to avoid this. I was not able to trigger the issue with the "enabled" option here (in PMG I was), but be on the safe side and coerce there too. Signed-off-by: Fabian Ebner --- Changes from v1: * avoid creating an implicit default by checking definedness first PVE/API2/APT.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index bd60db33..310d875f 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -750,13 +750,16 @@ __PACKAGE__->register_method({ code => sub { my ($param) = @_; + my $enabled = $param->{enabled}; + $enabled = int($enabled) if defined($enabled); + my $options = { - enabled => $param->{enabled}, + enabled => $enabled, }; PVE::RS::APT::Repositories::change_repository( $param->{path}, - $param->{index}, + int($param->{index}), $options, $param->{digest} ); -- 2.30.2