From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D1FF875EB8 for ; Wed, 14 Jul 2021 12:10:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C84EDF47C for ; Wed, 14 Jul 2021 12:09:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E314EF44A for ; Wed, 14 Jul 2021 12:09:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B85294175B for ; Wed, 14 Jul 2021 12:09:51 +0200 (CEST) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Wed, 14 Jul 2021 12:09:32 +0200 Message-Id: <20210714100933.54491-4-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210714100933.54491-1-d.jaeger@proxmox.com> References: <20210714100933.54491-1-d.jaeger@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.143 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 4/5 v2] dc options: Add apt notifications GUI checkbox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 10:10:23 -0000 Default value like pveupdate: Assume users with subscriptions want notifications Signed-off-by: Dominic Jäger --- v2: default depends on subscription status www/manager6/dc/OptionView.js | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index edae97ea..ec6ff1a3 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc/OptionView.js @@ -90,6 +90,43 @@ Ext.define('PVE.dc.OptionView', { vtype: 'proxmoxMail', defaultValue: 'root@$hostname', }); + me.add_inputpanel_row('notify', gettext('Notification settings'), { + renderer: PVE.Utils.render_dc_ha_opts, + labelWidth: 120, + url: "/api2/extjs/cluster/options", + items: [ + { + xtype: 'checkbox', + name: 'package_updates', + fieldLabel: gettext('Package updates'), + inputValue: 1, + uncheckedValue: 0, // behavior for undefined is different + listeners: { + added: function(checkbox) { + Proxmox.Utils.API2Request({ + url: '/nodes/localhost/subscription', + method: 'GET', + failure: function(response) { + console.warn('Unable to load subscription status: ' + + response.htmlStatus); + }, + success: function(response) { + const data = response.result.data; + // This happens after the row is clicked and the edit window + // opens but before the setValue from add_inputpanel_row sets + // the value that is (potentially) saved in datacenter.cfg. If + // no value is in datacenter.cfg then the setValue from + // add_inputpanel_row does nothing. Then this setValue uses the + // subscription status as default like pveupdate. + checkbox.setValue(data.status ==='Active'); + }, + }); + }, + }, + }, + ], + }); + me.add_text_row('mac_prefix', gettext('MAC address prefix'), { deleteEmpty: true, vtype: 'MacPrefix', -- 2.30.2