From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4390475AF0 for ; Tue, 13 Jul 2021 15:49:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34CFD23D3A for ; Tue, 13 Jul 2021 15:49:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B46EC23D2C for ; Tue, 13 Jul 2021 15:49:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 84AC541044 for ; Tue, 13 Jul 2021 15:49:07 +0200 (CEST) Date: Tue, 13 Jul 2021 15:49:06 +0200 From: Stoiko Ivanov To: Oguz Bektas Cc: Proxmox VE development discussion Message-ID: <20210713154906.3952b5cb@rosa.proxmox.com> In-Reply-To: <20210713123333.939899-1-o.bektas@proxmox.com> References: <20210713123333.939899-1-o.bektas@proxmox.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.463 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm] Subject: Re: [pve-devel] [PATCH v2 container] fix #3516: fix unmanaged containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 13:49:38 -0000 Thanks for providing the patch! code-wise LGTM - and it fixes the issue in my reproducer (a buster container where I manually changed the ostype to unmanaged) I think it would help to have a small comment above the line you inserted stating something like: # the code in PVE::LXC::Setup::Base is a generic check and should also # work for most other distros apart from that: Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov On Tue, 13 Jul 2021 14:33:33 +0200 Oguz Bektas wrote: > unmanaged containers should run the unified cgroupv2 code from our base > plugin so that they can start correctly instead of erroring out > > Signed-off-by: Oguz Bektas > --- > v1->v2: > * run code from base plugin instead of skipping it completely > > > src/PVE/LXC/Setup.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm > index 9abdc85..c4c73e1 100644 > --- a/src/PVE/LXC/Setup.pm > +++ b/src/PVE/LXC/Setup.pm > @@ -424,6 +424,8 @@ sub get_ct_os_release { > sub unified_cgroupv2_support { > my ($self) = @_; > > + $self->{plugin} //= 'PVE::LXC::Setup::Base'; # unmanaged > + > $self->protected_call(sub { > $self->{plugin}->unified_cgroupv2_support(); > });