From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CD32E75853 for ; Tue, 13 Jul 2021 10:09:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C34BD1D9DE for ; Tue, 13 Jul 2021 10:09:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5675B1D9D3 for ; Tue, 13 Jul 2021 10:09:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2A6F440F94 for ; Tue, 13 Jul 2021 10:09:23 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Tue, 13 Jul 2021 10:09:17 +0200 Message-Id: <20210713080917.1546780-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.507 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [openid.pm] Subject: [pve-devel] [PATCH access-control] fix #3513: pass configured proxy to OpenID X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 08:09:23 -0000 Signed-off-by: Fabian Grünbichler --- seemed like the easiest way to fix this - but we could also change the proxmox-openid-rs API to take the proxy as parameter.. src/PVE/API2/OpenId.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/API2/OpenId.pm b/src/PVE/API2/OpenId.pm index 22423ba..9080865 100644 --- a/src/PVE/API2/OpenId.pm +++ b/src/PVE/API2/OpenId.pm @@ -97,6 +97,9 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; + my $dcconf = PVE::Cluster::cfs_read_file('datacenter.cfg'); + local $ENV{all_proxy} = $dcconf->{http_proxy}; + my $realm = extract_param($param, 'realm'); my $redirect_url = extract_param($param, 'redirect-url'); @@ -149,6 +152,9 @@ __PACKAGE__->register_method ({ my $res; eval { + my $dcconf = PVE::Cluster::cfs_read_file('datacenter.cfg'); + local $ENV{all_proxy} = $dcconf->{http_proxy}; + my ($realm, $private_auth_state) = PVE::RS::OpenId::verify_public_auth_state( $openid_state_path, $param->{'state'}); -- 2.30.2