From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CD52E75518 for ; Mon, 12 Jul 2021 10:33:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C09D9127E3 for ; Mon, 12 Jul 2021 10:33:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 57800127DA for ; Mon, 12 Jul 2021 10:33:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 229C340FC6 for ; Mon, 12 Jul 2021 10:33:03 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Mon, 12 Jul 2021 10:32:48 +0200 Message-Id: <20210712083248.1736674-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.470 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 08:33:03 -0000 This is (afaics) a purely cosmetic change. With PVE 7.0 the ISO does not ship ifupdown/ifupdown2 in the installer environment anymore - ifup/ifdown are currently provided by busybox. Since we stop all daemonized processes with killall5, this takes care of the dhclient instances - so just drop the invocation of the non existing script. Noticed while checking out 2 improvments to the installer. Signed-off-by: Stoiko Ivanov --- unconfigured.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/unconfigured.sh b/unconfigured.sh index 98b8d9c..35ec0ee 100755 --- a/unconfigured.sh +++ b/unconfigured.sh @@ -47,8 +47,6 @@ eject_and_reboot() { real_reboot() { trap - ERR - /etc/init.d/networking stop - # stop udev (release file handles) /etc/init.d/udev stop -- 2.30.2