From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 55D517466E for ; Fri, 9 Jul 2021 10:49:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A94922180 for ; Fri, 9 Jul 2021 10:49:33 +0200 (CEST) Received: from mirage.deb.at (mirage.deb.at [IPv6:2001:858:10f:100::23:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4C8D722174 for ; Fri, 9 Jul 2021 10:49:32 +0200 (CEST) Received: by mirage.deb.at (Postfix, from userid 1000) id D85CF801EE; Fri, 9 Jul 2021 08:49:30 +0000 (UTC) Date: Fri, 9 Jul 2021 10:49:30 +0200 From: Rhonda D'Vine To: Fabian Ebner Cc: pve-devel@lists.proxmox.com Message-ID: <20210709084930.GA6337@mirage.deb.at> References: <20210709072441.8437-1-rhonda@deb.at> <20210709072441.8437-2-rhonda@deb.at> <1f1bddca-81c3-816e-6b57-fd6d15bec6d8@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1f1bddca-81c3-816e-6b57-fd6d15bec6d8@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve6to7.pm] Subject: Re: [pve-devel] [PATCH pve-manager 1/1] Only check deb sources.list entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jul 2021 08:49:33 -0000 Hi, * Fabian Ebner [2021-07-09 10:33:08 CEST]: > Am 09.07.21 um 09:24 schrieb Rhonda D'Vine: > > --- a/PVE/CLI/pve6to7.pm > > +++ b/PVE/CLI/pve6to7.pm > > @@ -1010,7 +1010,7 @@ sub check_security_repo { > > ($line) = split(/#/, $line); > > - next if $line !~ m/^deb/; # is case sensitive > > + next if $line !~ m/^deb[[:space:]]/; # is case sensitive > > my $suite; > > Of course, thank you for the fix! > > FWIW, Reviewed-by: Fabian Ebner > > I also noticed that the check is not yet in the stable-6 branch. Right, I didn't check which branches this should be applied, but I assume that the commit should apply without any troubles there too (and obviously would make more sense in that branch). Cheers, Rhonda -- Fühlst du dich mutlos, fass endlich Mut, los | Fühlst du dich hilflos, geh raus und hilf, los | Wir sind Helden Fühlst du dich machtlos, geh raus und mach, los | 23.55: Alles auf Anfang Fühlst du dich haltlos, such Halt und lass los |