From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E9B4C745DD for ; Fri, 9 Jul 2021 10:08:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE3EB21929 for ; Fri, 9 Jul 2021 10:08:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6EDD42191F for ; Fri, 9 Jul 2021 10:08:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 35FD040EFB for ; Fri, 9 Jul 2021 10:08:27 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 9 Jul 2021 10:08:22 +0200 Message-Id: <20210709080822.25576-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.537 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [info.property, w.property] Subject: [pve-devel] [PATCH widget-toolkit] node: repos: only show suites warning at the top if enabled repository is affected X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jul 2021 08:08:28 -0000 The warning still shows up for the disabled repository itself, but having a disabled repository with a bad suite is not problematic for the configuration status as a whole. Signed-off-by: Fabian Ebner --- src/node/APTRepositories.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index 4a37adb..c7222fc 100644 --- a/src/node/APTRepositories.js +++ b/src/node/APTRepositories.js @@ -665,9 +665,6 @@ Ext.define('Proxmox.node.APTRepositories', { (info.kind === 'ignore-pre-upgrade-warning' && !repoGrid.majorUpgradeAllowed) ) { infos[path][idx].warnings.push(info); - if (!suitesWarning && info.property === 'Suites') { - suitesWarning = true; - } } else { throw 'unknown info'; } @@ -682,6 +679,10 @@ Ext.define('Proxmox.node.APTRepositories', { if (infos[file.path] && infos[file.path][n]) { repo.Origin = infos[file.path][n].origin || Proxmox.Utils.UnknownText; repo.warnings = infos[file.path][n].warnings || []; + + if (repo.Enabled && repo.warnings.some(w => w.property === 'Suites')) { + suitesWarning = true; + } } gridData.push(repo); } -- 2.30.2